[PR #1181] [MERGED] Fixed a rename bug #1863

New issue

Closed

opened 2026-03-04 02:02:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1181
Author: @ggtakec
Created: 10/23/2019
Status: ✅ Merged
Merged: 10/31/2019
Merged by: @ggtakec

Base: master ← Head: fix_1171

📝 Commits (1)

cf3e82d Fixed a rename bug when enable_noobj_cache

📊 Changes

4 files changed (+129 additions, -5 deletions)

View changed files

📝 src/fdcache.cpp (+123 -2)
📝 src/fdcache.h (+2 -1)
📝 src/s3fs.cpp (+2 -0)
📝 test/integration-test-main.sh (+2 -2)

📄 Description

Relevant Issue (if applicable)

#1171 #1173

Details

The bug #1171 is due to forgetting to close the file descriptor in s3fs_rename() function.
This caused errors in tests after the test_rename_before_close test.

By correcting this forgetting to close, I discovered a problem in the rename processing.
During the rename processing, s3fs did not rename the file cache and file status cache.
In addition, the target file objects(FdEntity) were not detected properly when the cache directory was not specified.

Therefore, these two problems are corrected by this PR.

Also, the test code that temporarily avoided the error in #1173 has been restored.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1181 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 10/23/2019 **Status:** ✅ Merged **Merged:** 10/31/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix_1171` --- ### 📝 Commits (1) - [`cf3e82d`](https://github.com/s3fs-fuse/s3fs-fuse/commit/cf3e82d10aabc2f21bb903825682aa9fa43883a4) Fixed a rename bug when enable_noobj_cache ### 📊 Changes **4 files changed** (+129 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+123 -2) 📝 `src/fdcache.h` (+2 -1) 📝 `src/s3fs.cpp` (+2 -0) 📝 `test/integration-test-main.sh` (+2 -2) </details> ### 📄 Description ### Relevant Issue (if applicable) #1171 #1173 ### Details The bug #1171 is due to forgetting to close the file descriptor in s3fs_rename() function. This caused errors in tests after the test_rename_before_close test. By correcting this forgetting to close, I discovered a problem in the rename processing. During the rename processing, s3fs did not rename the file cache and file status cache. In addition, the target file objects(FdEntity) were not detected properly when the cache directory was not specified. Therefore, these two problems are corrected by this PR. Also, the test code that temporarily avoided the error in #1173 has been restored. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>