[PR #1142] [MERGED] Expose base parameter in s3fs_strtoofft #1847

New issue

Closed

opened 2026-03-04 02:02:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1142
Author: @gaul
Created: 9/5/2019
Status: ✅ Merged
Merged: 9/8/2019
Merged by: @ggtakec

Base: master ← Head: base

📝 Commits (1)

412876c Expose base parameter in s3fs_strtoofft

📊 Changes

5 files changed (+13 additions, -13 deletions)

View changed files

📝 src/curl.cpp (+3 -3)
📝 src/s3fs.cpp (+2 -2)
📝 src/string_util.cpp (+2 -2)
📝 src/string_util.h (+1 -1)
📝 src/test_string_util.cpp (+5 -5)

📄 Description

This fixes a regression from ccf3e7bfa2
which caused the misparsing of octal inputs for the mp_umask and umask
flags. It also allows some callers to be more precise about their
decimal inputs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1142 **Author:** [@gaul](https://github.com/gaul) **Created:** 9/5/2019 **Status:** ✅ Merged **Merged:** 9/8/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `base` --- ### 📝 Commits (1) - [`412876c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/412876ca33308d19bc0284c4496f765125c9f1cc) Expose base parameter in s3fs_strtoofft ### 📊 Changes **5 files changed** (+13 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+3 -3) 📝 `src/s3fs.cpp` (+2 -2) 📝 `src/string_util.cpp` (+2 -2) 📝 `src/string_util.h` (+1 -1) 📝 `src/test_string_util.cpp` (+5 -5) </details> ### 📄 Description This fixes a regression from ccf3e7bfa201428e06e2d97a70f277de981102e4 which caused the misparsing of octal inputs for the `mp_umask` and `umask` flags. It also allows some callers to be more precise about their decimal inputs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>