[PR #1126] [MERGED] Fixed multipart copy and its retry handler #1836

New issue

Closed

opened 2026-03-04 02:02:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1126
Author: @ggtakec
Created: 8/11/2019
Status: ✅ Merged
Merged: 8/11/2019
Merged by: @ggtakec

Base: master ← Head: fix_multipart_copy_retry

📝 Commits (1)

5c4a0a8 Fixed multipart copy and its retry handler

📊 Changes

3 files changed (+47 additions, -5 deletions)

View changed files

📝 src/curl.cpp (+42 -5)
📝 src/curl.h (+2 -0)
📝 src/s3fs.cpp (+3 -0)

📄 Description

Relevant Issue (if applicable)

#1102

Details

The concurrent write test failed when multipart copy failed and retry is executed.
This function and retry handler was incorrect, those were a mistake in the processing, and those implementation was insufficient.
If you change the permissions of a file larger than 5GB, multipart copy processing will be performed, but these will fail in the retry processing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1126 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 8/11/2019 **Status:** ✅ Merged **Merged:** 8/11/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix_multipart_copy_retry` --- ### 📝 Commits (1) - [`5c4a0a8`](https://github.com/s3fs-fuse/s3fs-fuse/commit/5c4a0a862af0f925383b0b69705ba0b4e2412352) Fixed multipart copy and its retry handler ### 📊 Changes **3 files changed** (+47 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+42 -5) 📝 `src/curl.h` (+2 -0) 📝 `src/s3fs.cpp` (+3 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #1102 ### Details The concurrent write test failed when multipart copy failed and retry is executed. This function and retry handler was incorrect, those were a mistake in the processing, and those implementation was insufficient. If you change the permissions of a file larger than 5GB, multipart copy processing will be performed, but these will fail in the retry processing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>