[PR #1085] [MERGED] Remove recursive locking #1801

New issue

Closed

opened 2026-03-04 02:02:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1085
Author: @gaul
Created: 7/10/2019
Status: ✅ Merged
Merged: 7/13/2019
Merged by: @ggtakec

Base: master ← Head: no-recusive-locks

📝 Commits (1)

a83d5ba Remove recursive locking

📊 Changes

7 files changed (+73 additions, -43 deletions)

View changed files

📝 .travis.yml (+3 -3)
📝 src/cache.cpp (+6 -4)
📝 src/cache.h (+3 -3)
📝 src/fdcache.cpp (+26 -20)
📝 src/fdcache.h (+4 -4)
📝 src/s3fs_util.cpp (+20 -4)
📝 src/s3fs_util.h (+11 -5)

📄 Description

Recursive locking is frowned upon and is incompatible with
PTHREAD_MUTEX_ERRORCHECK. Also clean up pthread_mutex_lock error
checking.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1085 **Author:** [@gaul](https://github.com/gaul) **Created:** 7/10/2019 **Status:** ✅ Merged **Merged:** 7/13/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `no-recusive-locks` --- ### 📝 Commits (1) - [`a83d5ba`](https://github.com/s3fs-fuse/s3fs-fuse/commit/a83d5baa90da1913f7de96016b9bf84aa57f5bdd) Remove recursive locking ### 📊 Changes **7 files changed** (+73 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+3 -3) 📝 `src/cache.cpp` (+6 -4) 📝 `src/cache.h` (+3 -3) 📝 `src/fdcache.cpp` (+26 -20) 📝 `src/fdcache.h` (+4 -4) 📝 `src/s3fs_util.cpp` (+20 -4) 📝 `src/s3fs_util.h` (+11 -5) </details> ### 📄 Description Recursive locking is frowned upon and is incompatible with `PTHREAD_MUTEX_ERRORCHECK`. Also clean up `pthread_mutex_lock` error checking. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>