credentials file #1765

New issue

Closed

opened 2026-03-04 02:02:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1021
Author: @michallula
Created: 4/25/2019
Status: ✅ Merged
Merged: 4/28/2019
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (1)

0d48475 fix issue with aws session token provided inside ~/.aws/credentials file

📊 Changes

3 files changed (+5 additions, -11 deletions)

View changed files

📝 src/curl.cpp (+1 -7)
📝 src/curl.h (+0 -1)
📝 src/s3fs.cpp (+4 -3)

📄 Description

Details

I fixed one issue that I discovered recently related to AWS session token support: when credentials are provided by ~/.aws/credentials file and session token is present, session token is not to request. I decided to remove set_is_session_token_use function from public interface of curl.cpp file. Instead of this I set the flag to true inside method SetAccessKeyWithSessionToken.

I hope code is cleaner right now and works fine. Sorry for introducing a bug in last PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1021 **Author:** [@michallula](https://github.com/michallula) **Created:** 4/25/2019 **Status:** ✅ Merged **Merged:** 4/28/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`0d48475`](https://github.com/s3fs-fuse/s3fs-fuse/commit/0d4847596e25fa2b3dd465612dd9e7e2df968366) fix issue with aws session token provided inside ~/.aws/credentials file ### 📊 Changes **3 files changed** (+5 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+1 -7) 📝 `src/curl.h` (+0 -1) 📝 `src/s3fs.cpp` (+4 -3) </details> ### 📄 Description ### Details I fixed one issue that I discovered recently related to AWS session token support: when credentials are provided by ~/.aws/credentials file and session token is present, session token is not to request. I decided to remove set_is_session_token_use function from public interface of curl.cpp file. Instead of this I set the flag to true inside method SetAccessKeyWithSessionToken. I hope code is cleaner right now and works fine. Sorry for introducing a bug in last PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>