[PR #967] [MERGED] Increase FdEntity reference count when returning #1733

New issue

Closed

opened 2026-03-04 02:01:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/967
Author: @gaul
Created: 3/5/2019
Status: ✅ Merged
Merged: 3/10/2019
Merged by: @ggtakec

Base: master ← Head: reference-count

📝 Commits (1)

f535034 Increase FdEntity reference count when returning

📊 Changes

4 files changed (+30 additions, -0 deletions)

View changed files

📝 src/fdcache.cpp (+11 -0)
📝 src/fdcache.h (+1 -0)
📝 src/s3fs.cpp (+3 -0)
📝 test/integration-test-main.sh (+15 -0)

📄 Description

Previously s3fs had a race condition where one client could delete
FdEntity that another client was using. Add a simple concurrent test
which previously failed but now succeeds. Fixes #964.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/967 **Author:** [@gaul](https://github.com/gaul) **Created:** 3/5/2019 **Status:** ✅ Merged **Merged:** 3/10/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `reference-count` --- ### 📝 Commits (1) - [`f535034`](https://github.com/s3fs-fuse/s3fs-fuse/commit/f53503438c28910a36fe2b155d6623c9af41d951) Increase FdEntity reference count when returning ### 📊 Changes **4 files changed** (+30 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+11 -0) 📝 `src/fdcache.h` (+1 -0) 📝 `src/s3fs.cpp` (+3 -0) 📝 `test/integration-test-main.sh` (+15 -0) </details> ### 📄 Description Previously s3fs had a race condition where one client could delete `FdEntity` that another client was using. Add a simple concurrent test which previously failed but now succeeds. Fixes #964. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>