[PR #960] [MERGED] Wtf8 #1730

New issue

Closed

opened 2026-03-04 02:01:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/960
Author: @kristjanvalur
Created: 2/19/2019
Status: ✅ Merged
Merged: 2/27/2019
Merged by: @ggtakec

Base: master ← Head: wtf8

📝 Commits (9)

ca2d1d8 Adding utility functions to convert invalid utf8 to wtf8 encoding
11b3858 more robust wtf8 encoding
4f42f4a Enable s3fs encoding and decoding in the fuse interface
e5b8377 fix comments and code
f336bde add command line flag and documentation
84c671a fix indentation
3c97c1b merged main
4c41eac fix documentation and man page
6e8678d remove lines that wer accidentally duplicated

📊 Changes

7 files changed (+293 additions, -28 deletions)

View changed files

📝 doc/man/s3fs.1 (+8 -0)
📝 src/s3fs.cpp (+79 -28)
📝 src/s3fs_util.cpp (+8 -0)
📝 src/string_util.cpp (+126 -0)
📝 src/string_util.h (+5 -0)
📝 src/test_string_util.cpp (+25 -0)
📝 src/test_util.h (+42 -0)

📄 Description

Details

S3 errors if object names are not utf-8. File system encodings are not required to be utf8, and in fact windows happily uses cp1252 to name files in NFS exports.

This change optionally examines the input path names and turns them into valid utf-8 code by using a private area of the Unicode namespace to store invalid utf8 bytes. The data are then converted back for listdir operations and readlink.

This allows encodings other than utf-8 for filenames.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/960 **Author:** [@kristjanvalur](https://github.com/kristjanvalur) **Created:** 2/19/2019 **Status:** ✅ Merged **Merged:** 2/27/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `wtf8` --- ### 📝 Commits (9) - [`ca2d1d8`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ca2d1d873d8f32bba857742f7af879511d2276d3) Adding utility functions to convert invalid utf8 to wtf8 encoding - [`11b3858`](https://github.com/s3fs-fuse/s3fs-fuse/commit/11b385820d7e271e811291ab646c71f6d2ded161) more robust wtf8 encoding - [`4f42f4a`](https://github.com/s3fs-fuse/s3fs-fuse/commit/4f42f4ab0c26f8b38d6514d3411be75950c28a1a) Enable s3fs encoding and decoding in the fuse interface - [`e5b8377`](https://github.com/s3fs-fuse/s3fs-fuse/commit/e5b8377202deb4b7d8da5e9e1d012f66d8775beb) fix comments and code - [`f336bde`](https://github.com/s3fs-fuse/s3fs-fuse/commit/f336bdebcc776c617d18cc4418c8e2e8158e7899) add command line flag and documentation - [`84c671a`](https://github.com/s3fs-fuse/s3fs-fuse/commit/84c671a81afd1f54e5f86de2120b5caa6e691f36) fix indentation - [`3c97c1b`](https://github.com/s3fs-fuse/s3fs-fuse/commit/3c97c1b2512b203d1bf9cd1e73c94d40999daef1) merged main - [`4c41eac`](https://github.com/s3fs-fuse/s3fs-fuse/commit/4c41eac29c399abeb6e50546e10c83eb3eb8b968) fix documentation and man page - [`6e8678d`](https://github.com/s3fs-fuse/s3fs-fuse/commit/6e8678d5e3db255dc40d2655647816316eeb38f5) remove lines that wer accidentally duplicated ### 📊 Changes **7 files changed** (+293 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `doc/man/s3fs.1` (+8 -0) 📝 `src/s3fs.cpp` (+79 -28) 📝 `src/s3fs_util.cpp` (+8 -0) 📝 `src/string_util.cpp` (+126 -0) 📝 `src/string_util.h` (+5 -0) 📝 `src/test_string_util.cpp` (+25 -0) 📝 `src/test_util.h` (+42 -0) </details> ### 📄 Description ### Details S3 errors if object names are not utf-8. File system encodings are not required to be utf8, and in fact windows happily uses cp1252 to name files in NFS exports. This change optionally examines the input path names and turns them into valid utf-8 code by using a private area of the Unicode namespace to store invalid utf8 bytes. The data are then converted back for listdir operations and readlink. This allows encodings other than utf-8 for filenames. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>