[PR #959] [MERGED] Fixed code for latest cppcheck error on OSX #1729

New issue

Closed

opened 2026-03-04 02:01:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/959
Author: @ggtakec
Created: 2/17/2019
Status: ✅ Merged
Merged: 2/17/2019
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (1)

eeb8392 Fixed code for latest cppcheck error on OSX

📊 Changes

6 files changed (+11 additions, -7 deletions)

View changed files

📝 Makefile.am (+2 -0)
📝 src/curl.cpp (+2 -3)
📝 src/gnutls_auth.cpp (+1 -0)
📝 src/s3fs.cpp (+3 -3)
📝 src/s3fs_util.cpp (+2 -0)
📝 src/string_util.cpp (+1 -1)

📄 Description

Relevant Issue (if applicable)

n/a

Details

With the upgrade of cppcheck used by OSX on TravisCI, cppcheck error appeared.
I corrected these errors.
Since the version of cppcheck depends on the build OS, the code for handling it complicates.
Therefore, inline cppcheck-suppress prevented it(Even if it is unnecessary code, I want to keep it).
Added --suppress=unmatchedSuppression and --xml(to show error id) in cppcheck options.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/959 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 2/17/2019 **Status:** ✅ Merged **Merged:** 2/17/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`eeb8392`](https://github.com/s3fs-fuse/s3fs-fuse/commit/eeb839242ba826707205b0b776c042203226d01b) Fixed code for latest cppcheck error on OSX ### 📊 Changes **6 files changed** (+11 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `Makefile.am` (+2 -0) 📝 `src/curl.cpp` (+2 -3) 📝 `src/gnutls_auth.cpp` (+1 -0) 📝 `src/s3fs.cpp` (+3 -3) 📝 `src/s3fs_util.cpp` (+2 -0) 📝 `src/string_util.cpp` (+1 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details With the upgrade of cppcheck used by OSX on TravisCI, cppcheck error appeared. I corrected these errors. Since the version of cppcheck depends on the build OS, the code for handling it complicates. Therefore, inline cppcheck-suppress prevented it(Even if it is unnecessary code, I want to keep it). Added --suppress=unmatchedSuppression and --xml(to show error id) in cppcheck options. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>