[PR #926] [MERGED] Accept paths with : in them #1705

New issue

Closed

opened 2026-03-04 02:01:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/926
Author: @kzidane
Created: 1/23/2019
Status: ✅ Merged
Merged: 1/27/2019
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (1)

cd794a6 Accept paths with : in them

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/s3fs.cpp (+1 -1)

📄 Description

Details

Paths with : in them (e.g., /foo:123) should be valid. The second call to strtok truncates anything after the second : in the bucket argument in the current version, so:

s3fs bucket:'/foo:123' '/tmp/foo:123'

ends up trying to mount bucket:/foo instead which isn't correct.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/926 **Author:** [@kzidane](https://github.com/kzidane) **Created:** 1/23/2019 **Status:** ✅ Merged **Merged:** 1/27/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`cd794a6`](https://github.com/s3fs-fuse/s3fs-fuse/commit/cd794a6985879533eb24546c4e6d2d1db8a34276) Accept paths with : in them ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+1 -1) </details> ### 📄 Description ### Details Paths with `:` in them (e.g., `/foo:123`) should be valid. The second call to `strtok` truncates anything after the second `:` in the bucket argument in the current version, so: ``` s3fs bucket:'/foo:123' '/tmp/foo:123' ``` ends up trying to mount `bucket:/foo` instead which isn't correct. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>