[PR #914] [MERGED] Issue readdir HEAD requests without batching #1697

New issue

Closed

opened 2026-03-04 02:01:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/914
Author: @gaul
Created: 1/21/2019
Status: ✅ Merged
Merged: 1/21/2019
Merged by: @ggtakec

Base: master ← Head: readdir/head-of-line

📝 Commits (1)

46d79c5 Issue readdir HEAD requests without batching

📊 Changes

4 files changed (+92 additions, -98 deletions)

View changed files

📝 src/curl.cpp (+17 -31)
📝 src/curl.h (+8 -4)
📝 src/psemaphore.h (+13 -3)
📝 src/s3fs.cpp (+54 -60)

📄 Description

Previously s3fs would issue a batch of HEAD requests and wait for all
to succeed before issuing the next batch. Now it issues the first
batch and only waits for a single call to succeed before issuing the
next call. This can improve performance when one call lags due to
network errors. I measured 25% improvement with the same level of
parallelism. This commit also reparents parallelism knobs for
consistency. Follows on to 88cd8feb05.
Fixes #223.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/914 **Author:** [@gaul](https://github.com/gaul) **Created:** 1/21/2019 **Status:** ✅ Merged **Merged:** 1/21/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `readdir/head-of-line` --- ### 📝 Commits (1) - [`46d79c5`](https://github.com/s3fs-fuse/s3fs-fuse/commit/46d79c5bc275c1df8cdd4e2ca0884efc68247e77) Issue readdir HEAD requests without batching ### 📊 Changes **4 files changed** (+92 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+17 -31) 📝 `src/curl.h` (+8 -4) 📝 `src/psemaphore.h` (+13 -3) 📝 `src/s3fs.cpp` (+54 -60) </details> ### 📄 Description Previously s3fs would issue a batch of HEAD requests and wait for all to succeed before issuing the next batch. Now it issues the first batch and only waits for a single call to succeed before issuing the next call. This can improve performance when one call lags due to network errors. I measured 25% improvement with the same level of parallelism. This commit also reparents parallelism knobs for consistency. Follows on to 88cd8feb053980c808d67771d63a84ca25f6db8a. Fixes #223. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>