[PR #882] [MERGED] [curl] Assume long encryption keys are base64 encoded #1672

New issue

Closed

opened 2026-03-04 02:01:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/882
Author: @earlchew
Created: 1/5/2019
Status: ✅ Merged
Merged: 1/6/2019
Merged by: @ggtakec

Base: master ← Head: issue-817

📝 Commits (2)

41c23ad [curl] Assume long encryption keys are base64 encoded
ed5795e [curl] Assume long encryption keys are base64 encoded

📊 Changes

1 file changed (+28 additions, -9 deletions)

View changed files

📝 src/curl.cpp (+28 -9)

📄 Description

Amazon SSE-C https://tinyurl.com/ychug4cg writes:

Use this header to provide the 256-bit, base64-encoded encryption key
for Amazon S3 to use to encrypt or decrypt your data.

It seems likely that future keys would be as long, or longer, so
this change assumes that text longer than 32 characters are keys
that are base64 encoded.

Signed-off-by: Earl Chew earl_chew@yahoo.com

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/882 **Author:** [@earlchew](https://github.com/earlchew) **Created:** 1/5/2019 **Status:** ✅ Merged **Merged:** 1/6/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `issue-817` --- ### 📝 Commits (2) - [`41c23ad`](https://github.com/s3fs-fuse/s3fs-fuse/commit/41c23adb0e10d3c276f2a81a5cf04fdff8740113) [curl] Assume long encryption keys are base64 encoded - [`ed5795e`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ed5795eead303551aacf4ff6e249b9573f4bbf3a) [curl] Assume long encryption keys are base64 encoded ### 📊 Changes **1 file changed** (+28 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+28 -9) </details> ### 📄 Description Amazon SSE-C https://tinyurl.com/ychug4cg writes: > Use this header to provide the 256-bit, base64-encoded encryption key > for Amazon S3 to use to encrypt or decrypt your data. It seems likely that future keys would be as long, or longer, so this change assumes that text longer than 32 characters are keys that are base64 encoded. Signed-off-by: Earl Chew <earl_chew@yahoo.com> ### Relevant Issue (if applicable) _If there are Issues related to this PullRequest, please list it._ ### Details _Please describe the details of PullRequest._ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>