[PR #832] [MERGED] Simplify hex conversion #1654

New issue

Closed

opened 2026-03-04 02:01:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/832
Author: @gaul
Created: 10/2/2018
Status: ✅ Merged
Merged: 10/8/2018
Merged by: @ggtakec

Base: master ← Head: hex

📝 Commits (1)

c703fa1 Simplify hex conversion

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 src/common_auth.cpp (+1 -3)

📄 Description

Addresses GCC 8 warning:

common_auth.cpp: In function ‘std::__cxx11::string s3fs_sha256sum(int, off_t, ssize_t)’:
common_auth.cpp:84:12: warning: ‘char* strncat(char*, const char*, size_t)’ output may be truncated copying 2 bytes from a string of length 2 [-Wstringop-truncation]
    strncat(sha256, hexbuf, 2);

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/832 **Author:** [@gaul](https://github.com/gaul) **Created:** 10/2/2018 **Status:** ✅ Merged **Merged:** 10/8/2018 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `hex` --- ### 📝 Commits (1) - [`c703fa1`](https://github.com/s3fs-fuse/s3fs-fuse/commit/c703fa15c0ea0eeee6e55c8f571308fc4af8cb46) Simplify hex conversion ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/common_auth.cpp` (+1 -3) </details> ### 📄 Description Addresses GCC 8 warning: ``` common_auth.cpp: In function ‘std::__cxx11::string s3fs_sha256sum(int, off_t, ssize_t)’: common_auth.cpp:84:12: warning: ‘char* strncat(char*, const char*, size_t)’ output may be truncated copying 2 bytes from a string of length 2 [-Wstringop-truncation] strncat(sha256, hexbuf, 2); ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>