[PR #780] [MERGED] gnutls_auth: initialize libgcrypt #1636

New issue

Closed

opened 2026-03-04 02:01:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/780
Author: @wjt
Created: 6/21/2018
Status: ✅ Merged
Merged: 6/24/2018
Merged by: @ggtakec

Base: master ← Head: initialize-libgcry

📝 Commits (1)

73cf2ba gnutls_auth: initialize libgcrypt

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/gnutls_auth.cpp (+5 -0)

📄 Description

Without this change, the following warning appears in the syslog/journal
during startup:

Libgcrypt warning: missing initialization - please fix the application

From the documentation:

The function gcry_check_version initializes some subsystems used by
Libgcrypt and must be invoked before any other function in the
library.

Fixes #524, which says:

gnutls is initialized by gnutls_global_init() function and
gcry_check_version() function for initializing libgcry is called from
this gnutls_global_init().

I checked the gnutls source and it hasn't contained a call to
gcry_check_version() since the libgcrypt backend was removed in 2011
(commit 8116cdc8f131edd586dad3128ae35dd744cfc32f). In any case, the
gcry_check_version() documentation continues:

It is important that these initialization steps are not done by a
library but by the actual application.

so it would be incorrect for a library used by s3fs to initialize
libgcrypt.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/780 **Author:** [@wjt](https://github.com/wjt) **Created:** 6/21/2018 **Status:** ✅ Merged **Merged:** 6/24/2018 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `initialize-libgcry` --- ### 📝 Commits (1) - [`73cf2ba`](https://github.com/s3fs-fuse/s3fs-fuse/commit/73cf2ba95d081c6f0871a4794ecdf56322da8c55) gnutls_auth: initialize libgcrypt ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/gnutls_auth.cpp` (+5 -0) </details> ### 📄 Description Without this change, the following warning appears in the syslog/journal during startup: Libgcrypt warning: missing initialization - please fix the application From the [documentation][0]: > The function `gcry_check_version` initializes some subsystems used by > Libgcrypt and must be invoked before any other function in the > library. Fixes #524, which says: > gnutls is initialized by gnutls_global_init() function and > gcry_check_version() function for initializing libgcry is called from > this gnutls_global_init(). I checked the gnutls source and it hasn't contained a call to gcry_check_version() since the libgcrypt backend was removed in 2011 (commit 8116cdc8f131edd586dad3128ae35dd744cfc32f). In any case, the gcry_check_version() documentation continues: > It is important that these initialization steps are not done by a > library but by the actual application. so it would be incorrect for a library used by s3fs to initialize libgcrypt. [0]: https://www.gnupg.org/documentation/manuals/gcrypt/Initializing-the-library.html --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>