[PR #769] [MERGED] Revert "enable FUSE read_sync by default" #1635

New issue

Closed

opened 2026-03-04 02:01:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/769
Author: @orozery
Created: 5/28/2018
Status: ✅ Merged
Merged: 5/28/2018
Merged by: @ggtakec

Base: master ← Head: revert_to_async_read

📝 Commits (1)

d4e86a1 Revert "enable FUSE read_sync by default"

📊 Changes

1 file changed (+0 additions, -16 deletions)

View changed files

📝 src/s3fs.cpp (+0 -16)

📄 Description

This reverts commit 86b0921ac4.

Details

I just found out that my recent commit causes single-file reading to be sometimes slower than before.
In commit 86b0921ac40ad0a34cd4202901efc2f4f774777b, I added by default the -o sync_read, to get better performance when reading multiple files at once.
Since it got merged, I tested some more, and found out that single-file reading performance has gotten worst.
I therefore think we should revert this commit.
The performance of reading multiple files at-once can be better if -o max_background is increased instead.

@ggtakec My apologies for this issue. Will greatly appreciate your prompt review & merge.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/769 **Author:** [@orozery](https://github.com/orozery) **Created:** 5/28/2018 **Status:** ✅ Merged **Merged:** 5/28/2018 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `revert_to_async_read` --- ### 📝 Commits (1) - [`d4e86a1`](https://github.com/s3fs-fuse/s3fs-fuse/commit/d4e86a17d127e39747cb38a13c72d4cc56894f90) Revert "enable FUSE read_sync by default" ### 📊 Changes **1 file changed** (+0 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+0 -16) </details> ### 📄 Description This reverts commit 86b0921ac40ad0a34cd4202901efc2f4f774777b. ### Details I just found out that my recent commit causes single-file reading to be sometimes slower than before. In commit `86b0921ac40ad0a34cd4202901efc2f4f774777b`, I added by default the `-o sync_read`, to get better performance when reading multiple files at once. Since it got merged, I tested some more, and found out that single-file reading performance has gotten worst. I therefore think we should revert this commit. The performance of reading multiple files at-once can be better if `-o max_background` is increased instead. @ggtakec My apologies for this issue. Will greatly appreciate your prompt review & merge. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>