[PR #754] [MERGED] Validate the URL format for http/https #1625

Closed
opened 2026-03-04 02:01:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/754
Author: @nkkashyap
Created: 5/3/2018
Status: Merged
Merged: 5/6/2018
Merged by: @ggtakec

Base: masterHead: master


📝 Commits (2)

  • ca87df7 Validate the URL format for http/https
  • 25375a6 Validate the URL fixed inefficient usage of find

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/s3fs.cpp (+5 -0)

📄 Description

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.
When the URL is specified without protocol detail like s3-api.us-geo.objectstorage.softlayer.net,
the s3fs process is silently terminating with exit code zero.
The code change validate the URL and throws error message if http / https is missing.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/754 **Author:** [@nkkashyap](https://github.com/nkkashyap) **Created:** 5/3/2018 **Status:** ✅ Merged **Merged:** 5/6/2018 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`ca87df7`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ca87df7d445bf97e7681a27a2c5c197a0cf0c137) Validate the URL format for http/https - [`25375a6`](https://github.com/s3fs-fuse/s3fs-fuse/commit/25375a6b4876b48ac3263b1bc873391957f4458e) Validate the URL fixed inefficient usage of find ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+5 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) _If there are Issues related to this PullRequest, please list it._ ### Details _Please describe the details of PullRequest._ When the URL is specified without protocol detail like `s3-api.us-geo.objectstorage.softlayer.net`, the `s3fs` process is silently terminating with exit code zero. The code change validate the URL and throws error message if `http` / `https` is missing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:01:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#1625
No description provided.