[PR #753] [MERGED] fix xpath selector in bucket listing #1624

New issue

Closed

opened 2026-03-04 02:01:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/753
Author: @cfz
Created: 4/23/2018
Status: ✅ Merged
Merged: 5/2/2018
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (1)

04493de fix xpath selector in bucket listing

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 src/s3fs.cpp (+5 -2)

📄 Description

the original implementation in get_base_exp() depends on the order of xml return from the server.
patriotically, when listing a directory with sub directory(s), the xml document response contains more than 2 nodes(some of them are in node).
the source code arbitrarily select the first one in the documents (nodes->nodeTab[0]->xmlChildrenNode), which is OK for aws.
however, some s3 compatible service return the list-bucket result in different order, leading the s3fs to a wrong behavior

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/753 **Author:** [@cfz](https://github.com/cfz) **Created:** 4/23/2018 **Status:** ✅ Merged **Merged:** 5/2/2018 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`04493de`](https://github.com/s3fs-fuse/s3fs-fuse/commit/04493de7677b5460cee0b97018e2d0d678560cb8) fix xpath selector in bucket listing ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+5 -2) </details> ### 📄 Description the original implementation in get_base_exp() depends on the order of xml return from the server. patriotically, when listing a directory with sub directory(s), the xml document response contains more than 2 <Prefix> nodes(some of them are in <CommonPrefixes> node). the source code arbitrarily select the first one in the documents (nodes->nodeTab[0]->xmlChildrenNode), which is OK for aws. however, some s3 compatible service return the list-bucket result in different order, leading the s3fs to a wrong behavior --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>