[PR #727] [MERGED] Fixed Travis CI error about cppcheck - #713 #1619

New issue

Closed

opened 2026-03-04 02:01:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/727
Author: @ggtakec
Created: 2/28/2018
Status: ✅ Merged
Merged: 2/28/2018
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (4)

960d45c Fixed cppcheck error on osx
a45ff6c Fixed cppcheck error and clean ^M code
c494e54 Fixed cppcheck error on osx
be9d407 Fixed cppcheck error on osx

📊 Changes

8 files changed (+146 additions, -152 deletions)

View changed files

📝 Makefile.am (+4 -3)
📝 src/addhead.cpp (+1 -1)
📝 src/curl.cpp (+12 -16)
📝 src/fdcache.cpp (+1 -1)
📝 src/gnutls_auth.cpp (+8 -8)
📝 src/nss_auth.cpp (+3 -3)
📝 src/s3fs.cpp (+115 -118)
📝 src/string_util.cpp (+2 -2)

📄 Description

Relevant Issue (if applicable)

#713

Details

The version of cppcheck prepared by TravisCI differs between OSX and ubuntu.
OSX was 1.82, and the behavior of unusedFunction was different from 1.63.
On OSX, exitcode = 0 does not become 0 even if suppressing unusedFunction error using suppress option.
Since it can not be helped, I adjust the option so as not to check unusedFunction.
In addition, we modified the code for the variableScope error and deleted it from the suppress option.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/727 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 2/28/2018 **Status:** ✅ Merged **Merged:** 2/28/2018 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`960d45c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/960d45c8536a1ac606c980c10a3420609d8fc499) Fixed cppcheck error on osx - [`a45ff6c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/a45ff6cdaac04c98d509e9c7bd5ee7d379a2fc5b) Fixed cppcheck error and clean ^M code - [`c494e54`](https://github.com/s3fs-fuse/s3fs-fuse/commit/c494e5432024d250798be06445b08c6bf12fb0af) Fixed cppcheck error on osx - [`be9d407`](https://github.com/s3fs-fuse/s3fs-fuse/commit/be9d407fa01dbb48598c36f996c4c5ed2adfde8f) Fixed cppcheck error on osx ### 📊 Changes **8 files changed** (+146 additions, -152 deletions) <details> <summary>View changed files</summary> 📝 `Makefile.am` (+4 -3) 📝 `src/addhead.cpp` (+1 -1) 📝 `src/curl.cpp` (+12 -16) 📝 `src/fdcache.cpp` (+1 -1) 📝 `src/gnutls_auth.cpp` (+8 -8) 📝 `src/nss_auth.cpp` (+3 -3) 📝 `src/s3fs.cpp` (+115 -118) 📝 `src/string_util.cpp` (+2 -2) </details> ### 📄 Description ### Relevant Issue (if applicable) #713 ### Details The version of cppcheck prepared by TravisCI differs between OSX and ubuntu. OSX was 1.82, and the behavior of unusedFunction was different from 1.63. On OSX, exitcode = 0 does not become 0 even if suppressing unusedFunction error using suppress option. Since it can not be helped, I adjust the option so as not to check unusedFunction. In addition, we modified the code for the variableScope error and deleted it from the suppress option. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>