[PR #671] [MERGED] Add support for ECS metadata endpoint #1597

New issue

Closed

opened 2026-03-04 02:01:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/671
Author: @psyvision
Created: 11/5/2017
Status: ✅ Merged
Merged: 11/19/2017
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (10+)

662f65c Add support for ECS metadata endpoint
5d54883 Remove commented out code
ccea87c Added check for is_ecs during get_access_keys
366f070 ECS credentials bug fixes
8660aba Use jsoncpp to parse AWS JSON
065516c Add jsoncpp to tavis config
395f736 Lower jsoncpp requirement
1cbe9fb Gotta pass that cppcheckgit add .
5df94d7 Add debug messages
a0b69d1 Corrected keyval[].c_str()

📊 Changes

6 files changed (+76 additions, -50 deletions)

View changed files

📝 .travis.yml (+2 -2)
📝 configure.ac (+5 -5)
📝 src/curl.cpp (+51 -41)
📝 src/curl.h (+2 -0)
📝 src/s3fs.cpp (+12 -2)
📝 src/s3fs_util.cpp (+4 -0)

📄 Description

This pull request resolves the issue of not using the ECS metadata endpoint when running under an ECS task role -> https://github.com/s3fs-fuse/s3fs-fuse/issues/507.

I haven't added any tests, I didn't see any that I thought were similar.

I haven't actually tested this on an ECS task yet - I will do this tomorrow!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/671 **Author:** [@psyvision](https://github.com/psyvision) **Created:** 11/5/2017 **Status:** ✅ Merged **Merged:** 11/19/2017 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`662f65c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/662f65c3c83a4df0f7b0f0ce61ed462937b83a2e) Add support for ECS metadata endpoint - [`5d54883`](https://github.com/s3fs-fuse/s3fs-fuse/commit/5d54883e2fa689859ffae489d88e546c41bccb31) Remove commented out code - [`ccea87c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ccea87ca683f423b9649bdb872dbe10ec3f09b3e) Added check for is_ecs during get_access_keys - [`366f070`](https://github.com/s3fs-fuse/s3fs-fuse/commit/366f0705a083f7ef8d6f5232c880a8a43b22c92e) ECS credentials bug fixes - [`8660aba`](https://github.com/s3fs-fuse/s3fs-fuse/commit/8660abaea26c014fff44ad15ced98f8c167900f9) Use jsoncpp to parse AWS JSON - [`065516c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/065516c5f3bd59f7cedd684edf6a599d95fd110b) Add jsoncpp to tavis config - [`395f736`](https://github.com/s3fs-fuse/s3fs-fuse/commit/395f73675385e98e45572d5fefe57c9523ebba84) Lower jsoncpp requirement - [`1cbe9fb`](https://github.com/s3fs-fuse/s3fs-fuse/commit/1cbe9fb7a367405236c7f0638df254a88e12640a) Gotta pass that cppcheckgit add . - [`5df94d7`](https://github.com/s3fs-fuse/s3fs-fuse/commit/5df94d7e339c17ce2c1464690710608360cb8509) Add debug messages - [`a0b69d1`](https://github.com/s3fs-fuse/s3fs-fuse/commit/a0b69d1d3d8eeb6dfb7a55f37a6638abf548cfe2) Corrected keyval[].c_str() ### 📊 Changes **6 files changed** (+76 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+2 -2) 📝 `configure.ac` (+5 -5) 📝 `src/curl.cpp` (+51 -41) 📝 `src/curl.h` (+2 -0) 📝 `src/s3fs.cpp` (+12 -2) 📝 `src/s3fs_util.cpp` (+4 -0) </details> ### 📄 Description This pull request resolves the issue of not using the ECS metadata endpoint when running under an ECS task role -> https://github.com/s3fs-fuse/s3fs-fuse/issues/507. I haven't added any tests, I didn't see any that I thought were similar. I haven't actually tested this on an ECS task yet - I will do this tomorrow! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>