[PR #664] [MERGED] auth headers insertion refactoring #1593

New issue

Closed

opened 2026-03-04 02:01:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/664
Author: @orozery
Created: 10/26/2017
Status: ✅ Merged
Merged: 11/5/2017
Merged by: @ggtakec

Base: master ← Head: auth_refactor

📝 Commits (1)

384b4cb auth headers insertion refactoring

📊 Changes

2 files changed (+152 additions, -248 deletions)

View changed files

📝 src/curl.cpp (+146 -247)
📝 src/curl.h (+6 -1)

📄 Description

Details

I refactored common authentication code (V2 & V4) to a single function called insertAuthHeaders.
This new function will allow to easily add support for other authentication mechanisms (such as Google Cloud Storage OAuth 2.0, or the IBM IAM Authentication - which I'm planning to add support to, once this PR is merged).

I've tested this PR using the integration tests, both in V4 & V2 modes - all seem to pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/664 **Author:** [@orozery](https://github.com/orozery) **Created:** 10/26/2017 **Status:** ✅ Merged **Merged:** 11/5/2017 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `auth_refactor` --- ### 📝 Commits (1) - [`384b4cb`](https://github.com/s3fs-fuse/s3fs-fuse/commit/384b4cbafa4dc842904a241c4d019bed23ce5bc6) auth headers insertion refactoring ### 📊 Changes **2 files changed** (+152 additions, -248 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+146 -247) 📝 `src/curl.h` (+6 -1) </details> ### 📄 Description #### Details I refactored common authentication code (V2 & V4) to a single function called insertAuthHeaders. This new function will allow to easily add support for other authentication mechanisms (such as Google Cloud Storage OAuth 2.0, or the IBM IAM Authentication - which I'm planning to add support to, once this PR is merged). I've tested this PR using the integration tests, both in V4 & V2 modes - all seem to pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>