[PR #608] [MERGED] Fix chown_nocopy losing existing uid/gid if unspecified #1570

New issue

Closed

opened 2026-03-04 02:01:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/608
Author: @tlevi
Created: 5/25/2017
Status: ✅ Merged
Merged: 5/28/2017
Merged by: @ggtakec

Base: master ← Head: chown_nocopy

📝 Commits (1)

cc94e1d Fix chown_nocopy losing existing uid/gid if unspecified

📊 Changes

1 file changed (+7 additions, -18 deletions)

View changed files

📝 src/s3fs.cpp (+7 -18)

📄 Description

When the s3fs_chown_nocopy function is used, performing chown with only owner or group loses the unspecified parameter.
This PR fills that data in from stbuf, the same as s3fs_chown already does.

I've also experimented with removing the nearby getpwuid/getgrgid calls, because I can't figure out what they're for, it seems like a no-op. If it needs to stay let me know.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/608 **Author:** [@tlevi](https://github.com/tlevi) **Created:** 5/25/2017 **Status:** ✅ Merged **Merged:** 5/28/2017 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `chown_nocopy` --- ### 📝 Commits (1) - [`cc94e1d`](https://github.com/s3fs-fuse/s3fs-fuse/commit/cc94e1da26bac8148efbdaf564e4d77ddbf1d96b) Fix chown_nocopy losing existing uid/gid if unspecified ### 📊 Changes **1 file changed** (+7 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+7 -18) </details> ### 📄 Description When the s3fs_chown_nocopy function is used, performing chown with only owner or group loses the unspecified parameter. This PR fills that data in from stbuf, the same as s3fs_chown already does. I've also experimented with removing the nearby getpwuid/getgrgid calls, because I can't figure out what they're for, it seems like a no-op. If it needs to stay let me know. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>