[PR #585] [MERGED] Fixed failure to upload/copy with SSE_C and SSE_KMS #1558

New issue

Closed

opened 2026-03-04 02:01:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/585
Author: @ggtakec
Created: 5/7/2017
Status: ✅ Merged
Merged: 5/7/2017
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (1)

a12e0d5 Fixed failure to upload/copy with SSE_C and SSE_KMS

📊 Changes

1 file changed (+25 additions, -8 deletions)

View changed files

📝 src/curl.cpp (+25 -8)

📄 Description

Relevant Issue (if applicable)

#584 #486

Details

In the case of SSE_C and SSE_KMS, the problem of file(object) upload/rename failed was fixed.

One cause is that the ETAG of the response is not MD5 when s3fs run with SSE_C and SSE_KMS parameter. Please see following document:
Http://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectPUT.html
Http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingKMSEncryption.html
@driskell pointed out this problem at #486 PR.

The cause of the malfunction of rename was that SSE_KMS header was added, despite the object was SSE_C before rename.

These bugs have been fixed.

NOTE:
@driskell, thanks for your kindness and I'm sorry for late fixing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/585 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 5/7/2017 **Status:** ✅ Merged **Merged:** 5/7/2017 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`a12e0d5`](https://github.com/s3fs-fuse/s3fs-fuse/commit/a12e0d5ec4a2ed0f087a68c1726ec3958a7ac7fc) Fixed failure to upload/copy with SSE_C and SSE_KMS ### 📊 Changes **1 file changed** (+25 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+25 -8) </details> ### 📄 Description #### Relevant Issue (if applicable) #584 #486 #### Details In the case of SSE_C and SSE_KMS, the problem of file(object) upload/rename failed was fixed. One cause is that the ETAG of the response is not MD5 when s3fs run with SSE_C and SSE_KMS parameter. Please see following document: Http://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectPUT.html Http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingKMSEncryption.html @driskell pointed out this problem at #486 PR. The cause of the malfunction of rename was that SSE_KMS header was added, despite the object was SSE_C before rename. These bugs have been fixed. NOTE: @driskell, thanks for your kindness and I'm sorry for late fixing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>