mirror of
https://github.com/s3fs-fuse/s3fs-fuse.git
synced 2026-04-25 13:26:00 +03:00
[PR #576] [MERGED] Added option for complementing lack of stat mode #1553
Labels
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/s3fs-fuse#1553
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/576
Author: @ggtakec
Created: 5/4/2017
Status: ✅ Merged
Merged: 5/4/2017
Merged by: @ggtakec
Base:
master← Head:master📝 Commits (1)
758b92eAdded option for complementing lack of stat mode📊 Changes
4 files changed (+35 additions, -1 deletions)
View changed files
📝
doc/man/s3fs.1(+4 -0)📝
src/common.h(+1 -0)📝
src/s3fs.cpp(+5 -0)📝
src/s3fs_util.cpp(+25 -1)📄 Description
Relevant Issue (if applicable)
n/a
(This is a request by direct mail.)
Details
If the object in S3 bucket was uploaded directly from the AWS S3 console or another tool incompatible with s3fs, it may not have the x-amz-meta-mode header required by s3fs or it's content type is not application/x-directory.
In this case, the object(file or directory) permission mode is 0, and even reading it can not.
In other words, if the object does not have the minimum necessary header, s3fs makes a strict judgment and the object is not authorized to operate.
However, with many users this mode=0 is confusing, and in the case of directories it is a problem that it can not be judged as a directory in particular.
Even if the x-amz-meta-mode does not exist or it can not be judged strictly as a directory, s3fs can predict that it is a directory and grants that it has the minimum permission (owner can read only for a file or read/excute for directory) by adding new option "complement_stat".
Thanks to Steven Marcus for giving the request!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.