[PR #466] [MERGED] Fixed a bug about could not copy file mode from org file #1515

New issue

Closed

opened 2026-03-04 02:00:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:00:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/466
Author: @ggtakec
Created: 9/11/2016
Status: ✅ Merged
Merged: 9/11/2016
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (4)

1a96f40 Fixed a bug about could not copy file mode from org file
f363c21 Added comments in failure message for test_chown
232befb Added small logic in test script for test_chown
ec110bb Added small logic in test script for test_chown

📊 Changes

2 files changed (+18 additions, -2 deletions)

View changed files

📝 src/s3fs.cpp (+11 -0)
📝 test/integration-test-main.sh (+7 -2)

📄 Description

This is a bug fix related to the #460.
If s3fs did not support xattrs, s3fs cound not copy file mode from original file when using "cp -p".
Thus this patch fixed this problem.
But now s3fs supports xattrs, then this patch does not effect to solve issue #460.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/466 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 9/11/2016 **Status:** ✅ Merged **Merged:** 9/11/2016 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`1a96f40`](https://github.com/s3fs-fuse/s3fs-fuse/commit/1a96f40a1048bc4a259715d1c7ca75de25c383e2) Fixed a bug about could not copy file mode from org file - [`f363c21`](https://github.com/s3fs-fuse/s3fs-fuse/commit/f363c21ff5a2efd71767d992dbc08b0b738e9d9a) Added comments in failure message for test_chown - [`232befb`](https://github.com/s3fs-fuse/s3fs-fuse/commit/232befb52a2cbca476f04839e7287fde765cf385) Added small logic in test script for test_chown - [`ec110bb`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ec110bb0f3ca33f9499a76011ae000c0bffac162) Added small logic in test script for test_chown ### 📊 Changes **2 files changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+11 -0) 📝 `test/integration-test-main.sh` (+7 -2) </details> ### 📄 Description This is a bug fix related to the #460. If s3fs did not support xattrs, s3fs cound not copy file mode from original file when using "cp -p". Thus this patch fixed this problem. But now s3fs supports xattrs, then this patch does not effect to solve issue #460. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>