[PR #444] [MERGED] Add mirror file logic for removing cache file #1510

New issue

Closed

opened 2026-03-04 02:00:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:00:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/444
Author: @ggtakec
Created: 7/3/2016
Status: ✅ Merged
Merged: 7/3/2016
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (1)

e8a8019 Add mirror file logic for removing cache file

📊 Changes

4 files changed (+120 additions, -17 deletions)

View changed files

📝 src/fdcache.cpp (+99 -16)
📝 src/fdcache.h (+3 -1)
📝 src/s3fs_util.cpp (+16 -0)
📝 src/s3fs_util.h (+2 -0)

📄 Description

This PR is for #428.

If the cache file is removed during upload/download a object, s3fs uploads/downloads the object which has some null bytes.
This patch changes a logic about upload/download when using cache files.
This new logic uses mirror file which is (hard) linked the cache file, then if the cache file is removed, s3fs can continue to upload/download a object without wrong data.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/444 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 7/3/2016 **Status:** ✅ Merged **Merged:** 7/3/2016 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`e8a8019`](https://github.com/s3fs-fuse/s3fs-fuse/commit/e8a8019a7111e28d23a1322ec9e0e6bbf6ebaf20) Add mirror file logic for removing cache file ### 📊 Changes **4 files changed** (+120 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+99 -16) 📝 `src/fdcache.h` (+3 -1) 📝 `src/s3fs_util.cpp` (+16 -0) 📝 `src/s3fs_util.h` (+2 -0) </details> ### 📄 Description This PR is for #428. If the cache file is removed during upload/download a object, s3fs uploads/downloads the object which has some null bytes. This patch changes a logic about upload/download when using cache files. This new logic uses mirror file which is (hard) linked the cache file, then if the cache file is removed, s3fs can continue to upload/download a object without wrong data. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>