[PR #346] [MERGED] Fix empty directory check against AWS S3 #1473

New issue

Closed

opened 2026-03-04 01:54:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:54:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/346
Author: @RobbKistler
Created: 2/5/2016
Status: ✅ Merged
Merged: 2/6/2016
Merged by: @ggtakec

Base: master ← Head: empty-dir

📝 Commits (1)

4eff6b4 Fix empty directory check against AWS S3

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 src/s3fs.cpp (+4 -2)

📄 Description

For ListBucketResult on an empty directory, AWS S3 and S3Proxy 1.4
differ. AWS will match the directory name, S3Proxy does not.

Changing max-keys=1 to max-keys-2 works for both implementations.
append_objects_from_xml() will swallow the directory key. The log
level of this message is changed from ERROR to DBG.

Fixes #345

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/346 **Author:** [@RobbKistler](https://github.com/RobbKistler) **Created:** 2/5/2016 **Status:** ✅ Merged **Merged:** 2/6/2016 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `empty-dir` --- ### 📝 Commits (1) - [`4eff6b4`](https://github.com/s3fs-fuse/s3fs-fuse/commit/4eff6b4dd17e1e2fa804593f47d17e8fa14a44e4) Fix empty directory check against AWS S3 ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+4 -2) </details> ### 📄 Description For ListBucketResult on an empty directory, AWS S3 and S3Proxy 1.4 differ. AWS will match the directory name, S3Proxy does not. Changing max-keys=1 to max-keys-2 works for both implementations. append_objects_from_xml() will swallow the directory key. The log level of this message is changed from ERROR to DBG. Fixes #345 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>