[PR #319] [MERGED] Clean up mount point on errors in s3fs_init() #1459

New issue

Closed

opened 2026-03-04 01:54:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:54:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/319
Author: @RobbKistler
Created: 12/15/2015
Status: ✅ Merged
Merged: 12/20/2015
Merged by: @ggtakec

Base: master ← Head: clean-exit

📝 Commits (2)

1927ccf Don't loop on fusermount if mountpoint is gone
b581290 Cleanly exit fuse loop on error in s3fs_init

📊 Changes

2 files changed (+21 additions, -4 deletions)

View changed files

📝 src/s3fs.cpp (+20 -3)
📝 test/small-integration-test.sh (+1 -1)

📄 Description

There are error conditions that don't get caught until s3fs_init() runs. Currently, s3fs_init calls exit(). This leaves the mount point behind and results in "Transport endpoint not connected" errors.

With this change, s3fs_init() will exit the fuse loop cleanly. This allows libfuse to close its session with the kernel module. The mount point will be unmounted.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/319 **Author:** [@RobbKistler](https://github.com/RobbKistler) **Created:** 12/15/2015 **Status:** ✅ Merged **Merged:** 12/20/2015 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `clean-exit` --- ### 📝 Commits (2) - [`1927ccf`](https://github.com/s3fs-fuse/s3fs-fuse/commit/1927ccfe0acefd4f58fa43cd1318290be73889fb) Don't loop on fusermount if mountpoint is gone - [`b581290`](https://github.com/s3fs-fuse/s3fs-fuse/commit/b581290c30931488db3d7f6268de9959bb255c26) Cleanly exit fuse loop on error in s3fs_init ### 📊 Changes **2 files changed** (+21 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+20 -3) 📝 `test/small-integration-test.sh` (+1 -1) </details> ### 📄 Description There are error conditions that don't get caught until s3fs_init() runs. Currently, s3fs_init calls exit(). This leaves the mount point behind and results in "Transport endpoint not connected" errors. With this change, s3fs_init() will exit the fuse loop cleanly. This allows libfuse to close its session with the kernel module. The mount point will be unmounted. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>