[PR #250] [MERGED] s3fs can print version with short commit hash - #228 #1424

Closed
opened 2026-03-04 01:53:53 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/250
Author: @ggtakec
Created: 8/21/2015
Status: Merged
Merged: 8/21/2015
Merged by: @ggtakec

Base: masterHead: issue#228


📝 Commits (2)

  • 751c868 s3fs can print version with short commit hash - #228
  • 8f8e52b s3fs can print version with short commit hash(2) - #228

📊 Changes

7 files changed (+66 additions, -9 deletions)

View changed files

📝 Makefile.am (+1 -1)
📝 autogen.sh (+22 -0)
📝 configure.ac (+35 -3)
📝 src/Makefile.am (+1 -1)
📝 src/common.h (+3 -0)
📝 src/s3fs.cpp (+2 -2)
📝 src/s3fs_util.cpp (+2 -2)

📄 Description

Added commit short hash in version string.
autogen.sh puts default_commit_hash in source root directory, and configure.ac makes config.h with it.
Because Makefile which is made by s3fs configure can build tar ball including source codes, it does not have .git directory.
But we should print commit hash base of source files which is made, when developer who has only tar ball builds binary.
So default_commit_hash file is included in tar ball, it can be printed.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/250 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 8/21/2015 **Status:** ✅ Merged **Merged:** 8/21/2015 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `issue#228` --- ### 📝 Commits (2) - [`751c868`](https://github.com/s3fs-fuse/s3fs-fuse/commit/751c8687697fa47f8bb906122bfe1cc73dd08851) s3fs can print version with short commit hash - #228 - [`8f8e52b`](https://github.com/s3fs-fuse/s3fs-fuse/commit/8f8e52b91a5986aecb5dfa45fea3ec581990592d) s3fs can print version with short commit hash(2) - #228 ### 📊 Changes **7 files changed** (+66 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Makefile.am` (+1 -1) 📝 `autogen.sh` (+22 -0) 📝 `configure.ac` (+35 -3) 📝 `src/Makefile.am` (+1 -1) 📝 `src/common.h` (+3 -0) 📝 `src/s3fs.cpp` (+2 -2) 📝 `src/s3fs_util.cpp` (+2 -2) </details> ### 📄 Description Added commit short hash in version string. autogen.sh puts default_commit_hash in source root directory, and configure.ac makes config.h with it. Because Makefile which is made by s3fs configure can build tar ball including source codes, it does not have .git directory. But we should print commit hash base of source files which is made, when developer who has only tar ball builds binary. So default_commit_hash file is included in tar ball, it can be printed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 01:53:53 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#1424
No description provided.