[PR #231] [MERGED] Rewrite AutoLock #1409

New issue

Closed

opened 2026-03-04 01:53:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:53:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/231
Author: @gaul
Created: 8/15/2015
Status: ✅ Merged
Merged: 8/19/2015
Merged by: @ggtakec

Base: master ← Head: autolock

📝 Commits (1)

3f59b8d Rewrite AutoLock

📊 Changes

2 files changed (+4 additions, -45 deletions)

View changed files

📝 src/s3fs_util.cpp (+3 -40)
📝 src/s3fs_util.h (+1 -5)

📄 Description

Previously AutoLock::Lock allowed subsequent callers to proceed
without the lock. Further is_locked was not always protected by
auto_mutex. Finally AutoLock eagerly released auto_mutex when
recursively unlocking. s3fs does not need recursive locks so we
rewrite and simplify AutoLock. Partially surfaced by Coverity.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/231 **Author:** [@gaul](https://github.com/gaul) **Created:** 8/15/2015 **Status:** ✅ Merged **Merged:** 8/19/2015 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `autolock` --- ### 📝 Commits (1) - [`3f59b8d`](https://github.com/s3fs-fuse/s3fs-fuse/commit/3f59b8da011cc5491db0a0cc60f749cb2ef6b9d9) Rewrite AutoLock ### 📊 Changes **2 files changed** (+4 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs_util.cpp` (+3 -40) 📝 `src/s3fs_util.h` (+1 -5) </details> ### 📄 Description Previously `AutoLock::Lock` allowed subsequent callers to proceed without the lock. Further `is_locked` was not always protected by `auto_mutex`. Finally `AutoLock` eagerly released `auto_mutex` when recursively unlocking. s3fs does not need recursive locks so we rewrite and simplify `AutoLock`. Partially surfaced by Coverity. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>