[PR #74] [MERGED] url: handle scheme omission #1339

New issue

Closed

opened 2026-03-04 01:53:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:53:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/74
Author: @vincentbernat
Created: 10/23/2014
Status: ✅ Merged
Merged: 10/26/2014
Merged by: @ggtakec

Base: master ← Head: fix/url-may-omit-scheme

📝 Commits (1)

7212072 url: handle scheme omission

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/string_util.cpp (+3 -1)

📄 Description

When the scheme is omitted in URL overriding (for example example.com
instead of https://example.com), s3fs is modifying the URL by
inserting s3. in the middle of the name (examples3..com).

This can be a bit difficult to troubleshoot and curl seems to handle
schema-less requests just fine. So, just handle this case correctly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/74 **Author:** [@vincentbernat](https://github.com/vincentbernat) **Created:** 10/23/2014 **Status:** ✅ Merged **Merged:** 10/26/2014 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix/url-may-omit-scheme` --- ### 📝 Commits (1) - [`7212072`](https://github.com/s3fs-fuse/s3fs-fuse/commit/7212072ff023d64ab86a557c3c8f118422b4b603) url: handle scheme omission ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/string_util.cpp` (+3 -1) </details> ### 📄 Description When the scheme is omitted in URL overriding (for example `example.com` instead of `https://example.com`), s3fs is modifying the URL by inserting `s3.` in the middle of the name (`examples3..com`). This can be a bit difficult to troubleshoot and curl seems to handle schema-less requests just fine. So, just handle this case correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>