[PR #3] [MERGED] Fixed local timezone was incorrectly being applied to IAM and Last-Modified dates. #1309

New issue

Closed

opened 2026-03-04 01:53:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:53:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/3
Author: @worpet
Created: 12/30/2013
Status: ✅ Merged
Merged: 1/1/2014
Merged by: @rrizun

Base: master ← Head: master

📝 Commits (1)

33ec373 Update s3fs_util.cpp

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/s3fs_util.cpp (+2 -2)

📄 Description

This issue was causing last modified file times to show incorrectly in cases where the last modified time was retrieved from the "Last-Modified" header. This can happen when files are added to a bucket outside of s3fs and do not have the "x-amz-meta-mtime" header.

timegm should be used to convert to time_t in UTC, rather than mktime.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/3 **Author:** [@worpet](https://github.com/worpet) **Created:** 12/30/2013 **Status:** ✅ Merged **Merged:** 1/1/2014 **Merged by:** [@rrizun](https://github.com/rrizun) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`33ec373`](https://github.com/s3fs-fuse/s3fs-fuse/commit/33ec3739e289a40883b9f687af037bce90582228) Update s3fs_util.cpp ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs_util.cpp` (+2 -2) </details> ### 📄 Description This issue was causing last modified file times to show incorrectly in cases where the last modified time was retrieved from the "Last-Modified" header. This can happen when files are added to a bucket outside of s3fs and do not have the "x-amz-meta-mtime" header. `timegm` should be used to convert to `time_t` in UTC, rather than `mktime`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>