[PR #1] [MERGED] Using %20 instead of the plus (+) sign for encoding spaces #1306

New issue

Closed

opened 2026-03-04 01:53:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:53:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1
Author: @dejaeghered
Created: 12/17/2013
Status: ✅ Merged
Merged: 12/17/2013
Merged by: @rrizun

Base: master ← Head: master

📝 Commits (1)

d5626fe Changed url encoding of space character to use %20 instead of the plus (+) sign.

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/string_util.cpp (+3 -1)

📄 Description

I am testing s3fs against a third party s3 storage solution and noticed s3fs-fuse using the plus character to encode spaces in URI. Avoiding the discussion about weither or not this should be ok. I believe the proper way of encoding spaces is the method specified in the HTTP standard, using "%20".

While Amazon accepts these requests they also say not to use them.

from Amazon @ http://docs.aws.amazon.com/general/latest/gr/signature-version-2.html

Note:
Be sure to URI encode the GET request. For example, blank spaces in your HTTP GET request should be encoded as %20. Although an unencoded space is normally allowed by the HTTP protocol specification, the use of unencoded characters creates an invalid signature in your Query request. Do not encode spaces as a plus sign (+) as this will cause errors.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1 **Author:** [@dejaeghered](https://github.com/dejaeghered) **Created:** 12/17/2013 **Status:** ✅ Merged **Merged:** 12/17/2013 **Merged by:** [@rrizun](https://github.com/rrizun) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`d5626fe`](https://github.com/s3fs-fuse/s3fs-fuse/commit/d5626fe595683075e300a5855fa27c6dab49e3fe) Changed url encoding of space character to use %20 instead of the plus (+) sign. ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/string_util.cpp` (+3 -1) </details> ### 📄 Description I am testing s3fs against a third party s3 storage solution and noticed s3fs-fuse using the plus character to encode spaces in URI. Avoiding the discussion about weither or not this should be ok. I believe the proper way of encoding spaces is the method specified in the HTTP standard, using "%20". While Amazon accepts these requests they also say not to use them. from Amazon @ http://docs.aws.amazon.com/general/latest/gr/signature-version-2.html Note: Be sure to URI encode the GET request. For example, blank spaces in your HTTP GET request should be encoded as %20. Although an unencoded space is normally allowed by the HTTP protocol specification, the use of unencoded characters creates an invalid signature in your Query request. Do not encode spaces as a plus sign (+) as this will cause errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>