mirror of
https://github.com/s3fs-fuse/s3fs-fuse.git
synced 2026-04-25 21:35:58 +03:00
[GH-ISSUE #2760] Obsolete nonempty check from fuse2 left, while fuse3 doesn't support nonempty #1288
Labels
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/s3fs-fuse#1288
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pschichtel on GitHub (Nov 30, 2025).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/2760
Additional Information
Version of s3fs being used (
s3fs --version)V1.96(commit:6235d0b +untracked files) with OpenSSL
Version of fuse being used (
pkg-config --modversion fuse,rpm -qi fuseordpkg -s fuse)libfuse3-4:amd64 3.17.2-3Provider (
AWS,OVH,Hetzner,iDrive E2, ...)Ceph RGW
Kernel information (
uname -r)GNU/Linux Distribution, if applicable (
cat /etc/os-release)PRETTY_NAME="Debian GNU/Linux 13 (trixie)"
NAME="Debian GNU/Linux"
VERSION_ID="13"
VERSION="13 (trixie)"
VERSION_CODENAME=trixie
DEBIAN_VERSION_FULL=13.2
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
How to run s3fs, if applicable
[X] command line
[] /etc/fstab
or
s3fs syslog messages (
grep s3fs /var/log/syslog,journalctl | grep s3fs, ors3fs outputs)or
Details about issue
When trying to mount s3fs to a non-empty directory, 1.95 allowed me to supply
-o nonemptyto allow that. With the switch to fuse3 1.96 started complaining, that-o nonemptydoesn't exist, because apparently fuse3 made-o nonemptythe default behavior. However, if I remove the nonempty option, s3fs then still complains that the folder is non-empty as with fuse2.The fact that with nonempty fuse is complaing and without it s3fs is complaining suggests, that there might be some obsolete code left from fuse2 times. And indeed, it seems like this section should probably be thrown out:
github.com/s3fs-fuse/s3fs-fuse@26f0f9e535/src/s3fs.cpp (L5055-L5070)@ggtakec commented on GitHub (Dec 4, 2025):
@pschichtel Thnaks for this issue post.
I've merged #2765 by @gaul, now.
@pschichtel commented on GitHub (Dec 4, 2025):
@ggtakec great! are there plans for some form of bugfix release?
@ggtakec commented on GitHub (Dec 4, 2025):
@pschichtel We're having that discussion in #2756, so please keep an eye on it.