`std::lock_guard` #1136

New issue

Closed

opened 2026-03-04 01:51:39 +03:00 by kerem · 1 comment

kerem commented

2026-03-04 01:51:39 +03:00

Owner

Originally created by @gaul on GitHub (Aug 6, 2023).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/2249

Now that s3fs requires C++11 we can use standard locking. The primary benefit is to better cooperate with Clang thread safety static analysis. It is possible that this is better for a future native Windows port as well. Note that this change is non-trivial due to the way that s3fs currently avoids recursive locking. It isn't obvious how to use the same flag pattern. My initial attempt at this shows some locking oddities that the dynamic ThreadSanitizer does not flag and may only coincidentally work.

Originally created by @gaul on GitHub (Aug 6, 2023). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/2249 Now that s3fs requires C++11 we can use standard locking. The primary benefit is to better cooperate with [Clang thread safety static analysis](https://clang.llvm.org/docs/ThreadSafetyAnalysis.html). It is possible that this is better for a future native Windows port as well. Note that this change is non-trivial due to the way that s3fs currently avoids recursive locking. It isn't obvious how to use the same flag pattern. My initial attempt at this shows some locking oddities that the dynamic ThreadSanitizer does not flag and may only coincidentally work.