[GH-ISSUE #195] Audit string concatentations for appending single-character string literals #109

New issue

Closed

opened 2026-03-04 01:42:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:42:12 +03:00

Owner

Originally created by @gaul on GitHub (Jun 10, 2015).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/195

We can replace these with appending single-character char literals. Suggested by @UnitedMarsupials in github.com/andrewgaul/s3fs-fuse@4e03acf17a (commitcomment-11620370). Current call sites:

$ grep -rI '+= *".";' *
src/s3fs.cpp:    newpath += "/";
src/s3fs.cpp:    strpath += "/";
src/s3fs.cpp:      strpath    += "/";
src/s3fs.cpp:          strpath += "/";
src/s3fs.cpp:          strpath += "/";
src/s3fs.cpp:    strpath += "/";
src/s3fs.cpp:    tpath += "/";
src/s3fs.cpp:    strpath += "/";
src/s3fs.cpp:  strto += "/";
src/s3fs.cpp:    strpath += "/";
src/s3fs.cpp:    query_delimiter += "&";
src/s3fs.cpp:            next_marker += "/";
src/s3fs.cpp:          withdirname += "/";
src/curl.cpp:    range       += "-";
src/curl.cpp:    turl += "?";
src/curl.cpp:    query_string += "=";
src/curl.cpp:      sorted_headers += ";";
src/cache.cpp:    strpath += "/";
src/cache.cpp:    strpath += "/";
src/cache.cpp:      strpath += "/";
src/string_util.cpp:      result += "%";
src/string_util.cpp:      result += "%";
src/s3fs_util.cpp:      newname += "/";
src/s3fs_util.cpp:        strtmp += "/";
src/s3fs_util.cpp:    fullpath         += "/";

Originally created by @gaul on GitHub (Jun 10, 2015). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/195 We can replace these with appending single-character char literals. Suggested by @UnitedMarsupials in https://github.com/andrewgaul/s3fs-fuse/commit/4e03acf17ad825458aa435c0f3fed9badfbb0a05#commitcomment-11620370. Current call sites: ``` $ grep -rI '+= *".";' * src/s3fs.cpp: newpath += "/"; src/s3fs.cpp: strpath += "/"; src/s3fs.cpp: strpath += "/"; src/s3fs.cpp: strpath += "/"; src/s3fs.cpp: strpath += "/"; src/s3fs.cpp: strpath += "/"; src/s3fs.cpp: tpath += "/"; src/s3fs.cpp: strpath += "/"; src/s3fs.cpp: strto += "/"; src/s3fs.cpp: strpath += "/"; src/s3fs.cpp: query_delimiter += "&"; src/s3fs.cpp: next_marker += "/"; src/s3fs.cpp: withdirname += "/"; src/curl.cpp: range += "-"; src/curl.cpp: turl += "?"; src/curl.cpp: query_string += "="; src/curl.cpp: sorted_headers += ";"; src/cache.cpp: strpath += "/"; src/cache.cpp: strpath += "/"; src/cache.cpp: strpath += "/"; src/string_util.cpp: result += "%"; src/string_util.cpp: result += "%"; src/s3fs_util.cpp: newname += "/"; src/s3fs_util.cpp: strtmp += "/"; src/s3fs_util.cpp: fullpath += "/"; ```