[GH-ISSUE #275] Use Rust edition 2021 #83

New issue

Closed

opened 2026-02-27 20:23:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:23:01 +03:00

Owner

Originally created by @marioortizmanero on GitHub (Oct 21, 2021).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/275

Is your feature request related to a problem? Please describe.
Rust 1.56 has been released, and with it, the 2021 edition. There's lots of cool changes. The problem is that if we started using it right now we'd force all the users of Rspotify to use rustc 1.56, so we should leave it for the future.

Reference: https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html

Describe the solution you'd like

We should probably add the rust-version field to the Cargo.tomls
We should remove resolver = "2" from the Cargo.tomls, since that's default now
Try removing the build_map and build_json macros now that HashMap::from([(a,b), (c,d)]) is possible (only in case it looks great).
Any other things that come up. We should run cargo fix --edition just in case.

FWIW, Rspotify seems to compile just fine with v1.56, so that's not a problem.

Originally created by @marioortizmanero on GitHub (Oct 21, 2021). Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/275 **Is your feature request related to a problem? Please describe.** Rust 1.56 has been released, and with it, the 2021 edition. There's lots of cool changes. The problem is that if we started using it right now we'd force all the users of Rspotify to use rustc 1.56, so we should leave it for the future. Reference: https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html **Describe the solution you'd like** * We should probably add the `rust-version` field to the `Cargo.toml`s * We should remove `resolver = "2"` from the `Cargo.toml`s, since that's default now * Try removing the `build_map` and `build_json` macros now that `HashMap::from([(a,b), (c,d)])` is possible (only in case it looks great). * Any other things that come up. We should run `cargo fix --edition` just in case. FWIW, Rspotify seems to compile just fine with v1.56, so that's not a problem.