[PR #540] [MERGED] feat: handle port not set and reverse proxy #523

New issue

Closed

opened 2026-02-27 20:25:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:25:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/540
Author: @ilteoood
Created: 10/21/2025
Status: ✅ Merged
Merged: 10/22/2025
Merged by: @ramsayleung

Base: master ← Head: master

📝 Commits (3)

0ce9da0 feat: use default port
d500a28 fix: ip address
7f9ae3c fix: code review

📊 Changes

1 file changed (+55 additions, -32 deletions)

View changed files

📝 src/clients/oauth.rs (+55 -32)

📄 Description

Description

With this PR I would like to handle a couple of scenarios:

when the port is not defined, use the protocol's default one (http 80, https 443)
an app build with rspotify is hosted behind a reverse proxy

Motivation and Context

When the app is containerized + behind a reverse proxy, using the reverse proxy url makes the server to fail to start.

Dependencies

List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested?

Changing the test scenario for the get_socket_address function.

Is this change properly documented?

Please make sure you've properly documented the changes you're making.

Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/540 **Author:** [@ilteoood](https://github.com/ilteoood) **Created:** 10/21/2025 **Status:** ✅ Merged **Merged:** 10/22/2025 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`0ce9da0`](https://github.com/ramsayleung/rspotify/commit/0ce9da0608129d61b52078ccb5048f0064b27c2f) feat: use default port - [`d500a28`](https://github.com/ramsayleung/rspotify/commit/d500a28fcb37361e4668044c8065721d638eca79) fix: ip address - [`7f9ae3c`](https://github.com/ramsayleung/rspotify/commit/7f9ae3c3ef9f4cc21ccb75c89023ececf8485b40) fix: code review ### 📊 Changes **1 file changed** (+55 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `src/clients/oauth.rs` (+55 -32) </details> ### 📄 Description ## Description With this PR I would like to handle a couple of scenarios: - when the port is not defined, use the protocol's default one (http 80, https 443) - an app build with rspotify is hosted behind a reverse proxy ## Motivation and Context When the app is containerized + behind a reverse proxy, using the reverse proxy url makes the server to fail to start. ## Dependencies List any dependencies that are required for this change. ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How has this been tested? Changing the test scenario for the `get_socket_address` function. ## Is this change properly documented? Please make sure you've properly documented the changes you're making. Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>