[PR #529] [MERGED] fix(model): handle null images on FullPlaylist model #517

Closed
opened 2026-02-27 20:25:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/529
Author: @lazulit3
Created: 6/18/2025
Status: Merged
Merged: 6/19/2025
Merged by: @ramsayleung

Base: masterHead: fix-fullplaylist-null-images


📝 Commits (1)

  • 5ee88dd fix(model): handle null images on FullPlaylist model

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 rspotify-model/src/playlist.rs (+1 -0)

📄 Description

Description

Fixes a deserialization error that occurs when spotify returns a playlist with "images": null when deserializing into FullPlaylist.

This was fixed for SimplifiedPlaylist, but we need the fix for FullPlaylist as well:

json parse error: invalid type: null, expected a sequence at line 1 column 275

Motivation and Context

I am using playlist() to fetch a playlist by its ID, and my playlist has no tracks (and therefor no images), and I'm encountering this deserialization error that I'd like to fix.

Dependencies

None.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

I've pointed my project at my fork (on this branch) and verified that this resolves the deserialization failure.

Is this change properly documented?

Not documented.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/529 **Author:** [@lazulit3](https://github.com/lazulit3) **Created:** 6/18/2025 **Status:** ✅ Merged **Merged:** 6/19/2025 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `fix-fullplaylist-null-images` --- ### 📝 Commits (1) - [`5ee88dd`](https://github.com/ramsayleung/rspotify/commit/5ee88dd0affa6687b691a068f17612373af8bfd8) fix(model): handle null images on FullPlaylist model ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `rspotify-model/src/playlist.rs` (+1 -0) </details> ### 📄 Description ## Description Fixes a deserialization error that occurs when spotify returns a playlist with `"images": null` when deserializing into `FullPlaylist`. This was fixed for `SimplifiedPlaylist`, but we need the fix for `FullPlaylist` as well: - https://github.com/ramsayleung/rspotify/pull/480 - https://github.com/ramsayleung/rspotify/issues/459 ``` json parse error: invalid type: null, expected a sequence at line 1 column 275 ``` ## Motivation and Context I am using `playlist()` to fetch a playlist by its ID, and my playlist has no tracks (and therefor no images), and I'm encountering this deserialization error that I'd like to fix. ## Dependencies None. ## Type of change Please delete options that are not relevant. - [X] Bug fix (non-breaking change which fixes an issue) ## How has this been tested? I've pointed my project at my fork (on this branch) and verified that this resolves the deserialization failure. ## Is this change properly documented? Not documented. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:25:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#517
No description provided.