[PR #510] [MERGED] Fix failed CI job by resolving elided-named-lifetimes clippy rule and fixing failed wasm test. #503

New issue

Closed

opened 2026-02-27 20:24:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/510
Author: @ramsayleung
Created: 12/24/2024
Status: ✅ Merged
Merged: 12/25/2024
Merged by: @ramsayleung

Base: master ← Head: ramsay/fix-clippy-error

📝 Commits (8)

0d5b4fe Fix elided-named-lifetimes clippy rule.
b7fe06d Fix format error.
f5e51d4 Allow unreachable pattern for serde alias.
0cdaf1f fix unreachable pattern clippy error.
66ef592 add more verbose output for wasm to help debug
b5d01c7 Update waasm-pack test command argument
40b5d56 Upgrade node to 20 to run wasm-pack test.
41c3b88 Rollback headless and other browser test.

📊 Changes

4 files changed (+17 additions, -17 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -0)
📝 rspotify-model/src/custom_serde.rs (+1 -1)
📝 rspotify-model/src/error.rs (+0 -2)
📝 src/clients/base.rs (+14 -14)

📄 Description

Description

Fix failed CI job by resolving elided-named-lifetimes clippy rule.

Motivation and Context

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested?

cargo clippy -p rspotify -p rspotify-http -p rspotify-model -p rspotify-macros --no-default-features --features=rspotify/cli,rspotify/env-file,rspotify/client-reqwest,rspotify/reqwest-rustls-tls,rspotify-http/client-reqwest,rspotify-http/reqwest-rustls-tls --all-targets -- -D warnings

build succeeded.

Is this change properly documented?

It's unnecessary.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/510 **Author:** [@ramsayleung](https://github.com/ramsayleung) **Created:** 12/24/2024 **Status:** ✅ Merged **Merged:** 12/25/2024 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `ramsay/fix-clippy-error` --- ### 📝 Commits (8) - [`0d5b4fe`](https://github.com/ramsayleung/rspotify/commit/0d5b4fe8dd00a2394b25c2cdf6fa45ff98f8b8b1) Fix elided-named-lifetimes clippy rule. - [`b7fe06d`](https://github.com/ramsayleung/rspotify/commit/b7fe06d890135b3374db7d52f6438d0a64b1bc3c) Fix format error. - [`f5e51d4`](https://github.com/ramsayleung/rspotify/commit/f5e51d47f3ad555e7da0c1b689c1d10ce5395a46) Allow unreachable pattern for serde alias. - [`0cdaf1f`](https://github.com/ramsayleung/rspotify/commit/0cdaf1f45e38a6321ced975ca5e7b4d8136d1dc4) fix unreachable pattern clippy error. - [`66ef592`](https://github.com/ramsayleung/rspotify/commit/66ef592133015a18c3724a54cca5908018e9d41e) add more verbose output for wasm to help debug - [`b5d01c7`](https://github.com/ramsayleung/rspotify/commit/b5d01c728e02dcdbe8ba01b37fac57efc31ca68e) Update waasm-pack test command argument - [`40b5d56`](https://github.com/ramsayleung/rspotify/commit/40b5d5601bae9c9acabc7e092d40b107f758ac17) Upgrade node to 20 to run wasm-pack test. - [`41c3b88`](https://github.com/ramsayleung/rspotify/commit/41c3b8868401892ddfe00fa82b79e24b6ec0e7bb) Rollback headless and other browser test. ### 📊 Changes **4 files changed** (+17 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -0) 📝 `rspotify-model/src/custom_serde.rs` (+1 -1) 📝 `rspotify-model/src/error.rs` (+0 -2) 📝 `src/clients/base.rs` (+14 -14) </details> ### 📄 Description ## Description Fix failed CI job by resolving elided-named-lifetimes clippy rule. ## Motivation and Context - https://github.com/ramsayleung/rspotify/actions/runs/12473292920/job/34813544989?pr=509 - https://doc.rust-lang.org/rustc/lints/listing/warn-by-default.html#elided-named-lifetimes ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How has this been tested? ```sh cargo clippy -p rspotify -p rspotify-http -p rspotify-model -p rspotify-macros --no-default-features --features=rspotify/cli,rspotify/env-file,rspotify/client-reqwest,rspotify/reqwest-rustls-tls,rspotify-http/client-reqwest,rspotify-http/reqwest-rustls-tls --all-targets -- -D warnings ``` build succeeded. ## Is this change properly documented? It's unnecessary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>