[PR #490] [MERGED] add derivable traits to PlayableId and PlayContextId #489

New issue

Closed

opened 2026-02-27 20:24:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/490
Author: @SebRollen
Created: 8/22/2024
Status: ✅ Merged
Merged: 8/22/2024
Merged by: @ramsayleung

Base: master ← Head: playable-id-impl

📝 Commits (2)

9820e3b add derivable traits to PlayableId and PlayContextId
9ecd74c update readme

📊 Changes

2 files changed (+3 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 rspotify-model/src/idtypes.rs (+2 -0)

📄 Description

Description

This PR derives the traits Clone, Debug, PartialEq, Eq, Serialize and Hash for PlayContextId and PlayableId. These two types are enums around other ID types that already derive the same traits.

Motivation and Context

I'm currently working on a feature in a downstream crate and there are a few places where we could simplify the code a lot by having these traits be implemented for PlayableId. I have less need of the same for PlayContextId, but figured I might as well add that to the PR so that all IDs are covered.

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested?

Not tested

Is this change properly documented?

Changelog updated

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/490 **Author:** [@SebRollen](https://github.com/SebRollen) **Created:** 8/22/2024 **Status:** ✅ Merged **Merged:** 8/22/2024 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `playable-id-impl` --- ### 📝 Commits (2) - [`9820e3b`](https://github.com/ramsayleung/rspotify/commit/9820e3b26a990ae7b8c8f9a2ea28a8db3a23a5d7) add derivable traits to PlayableId and PlayContextId - [`9ecd74c`](https://github.com/ramsayleung/rspotify/commit/9ecd74c397577ca42dd6519da918836b668f4d2e) update readme ### 📊 Changes **2 files changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `rspotify-model/src/idtypes.rs` (+2 -0) </details> ### 📄 Description ## Description This PR derives the traits `Clone`, `Debug`, `PartialEq`, `Eq`, `Serialize` and `Hash` for `PlayContextId` and `PlayableId`. These two types are enums around other ID types that already derive the same traits. ## Motivation and Context I'm currently working on [a feature in a downstream crate](https://github.com/aome510/spotify-player/pull/552) and there are a few places where we could simplify the code a lot by having these traits be implemented for `PlayableId`. I have less need of the same for `PlayContextId`, but figured I might as well add that to the PR so that all IDs are covered. ## Dependencies None ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How has this been tested? Not tested ## Is this change properly documented? Changelog updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>