[PR #487] [MERGED] Fix JSON deserialize error that TrackLink::id could be null #488

New issue

Closed

opened 2026-02-27 20:24:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/487
Author: @ramsayleung
Created: 8/3/2024
Status: ✅ Merged
Merged: 8/5/2024
Merged by: @ramsayleung

Base: master ← Head: ramsay/fix-tracklink-id-null

📝 Commits (4)

7f31f46 Fix JSON deserialize error that TrackLink::id could be null
1df76ee Update CHANGELOG.md.
7836a69 Fix format error.
41c2127 Fix doc error.

📊 Changes

3 files changed (+28 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 rspotify-model/src/track.rs (+5 -1)
📝 tests/test_models.rs (+19 -0)

📄 Description

Description

Fix JSON deserialize error that TrackLink::id could be null, and add the missing type and uri field for TrackLink based on the updated Spotify document: https://developer.spotify.com/documentation/web-api/concepts/track-relinking

Motivation and Context

https://github.com/ramsayleung/rspotify/issues/486

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested?

All CI jobs pass
newly added unit test: test_null_id_in_track_link pass

Is this change properly documented?

Yes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/487 **Author:** [@ramsayleung](https://github.com/ramsayleung) **Created:** 8/3/2024 **Status:** ✅ Merged **Merged:** 8/5/2024 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `ramsay/fix-tracklink-id-null` --- ### 📝 Commits (4) - [`7f31f46`](https://github.com/ramsayleung/rspotify/commit/7f31f4639557dbb8699369b4c05248af3d5a3b77) Fix JSON deserialize error that TrackLink::id could be null - [`1df76ee`](https://github.com/ramsayleung/rspotify/commit/1df76ee3c97ef7c0b5ca1579c308da7e144d6651) Update CHANGELOG.md. - [`7836a69`](https://github.com/ramsayleung/rspotify/commit/7836a69bd6978bf470d49541f50616428f5110ab) Fix format error. - [`41c2127`](https://github.com/ramsayleung/rspotify/commit/41c2127075b3fc40742f2231729c780026a9711f) Fix doc error. ### 📊 Changes **3 files changed** (+28 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `rspotify-model/src/track.rs` (+5 -1) 📝 `tests/test_models.rs` (+19 -0) </details> ### 📄 Description ## Description Fix JSON deserialize error that TrackLink::id could be null, and add the missing `type` and `uri` field for TrackLink based on the updated Spotify document: https://developer.spotify.com/documentation/web-api/concepts/track-relinking ## Motivation and Context - https://github.com/ramsayleung/rspotify/issues/486 ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How has this been tested? - All CI jobs pass - newly added unit test: test_null_id_in_track_link pass ## Is this change properly documented? Yes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>