[PR #463] [MERGED] [Fix] Fix the filter of GitHub Action on event #473

New issue

Closed

opened 2026-02-27 20:24:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/463
Author: @ramsayleung
Created: 3/8/2024
Status: ✅ Merged
Merged: 3/8/2024
Merged by: @ramsayleung

Base: master ← Head: ramsay/fix-github-action-on-filter

📝 Commits (1)

7cbf2db [fix] Fix the filter of on event, only trigger the workflow when new tag named

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 .github/workflows/publish.yaml (+1 -1)

📄 Description

Description

Fix the filter of GitHub Action on event

Motivation and Context

The on section specifies the events that trigger workflow, what I expect is the workflow only get triggered when new tag name v* is created(e.g. new version is published).

However, the current configuration will trigger the workflow not only when a new tag is created but also when any other type of creation event occurs(such as creating a new branch)

Fixing it by enclosing the tag pattern 'v*' in single quotes, it should explicitly specfy that the workflow should trigger only when a new tg matching that pattern is created.

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested?

This PR shoudn't trigger the Publish Create workflow

Is this change properly documented?

It's unnecessary.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/463 **Author:** [@ramsayleung](https://github.com/ramsayleung) **Created:** 3/8/2024 **Status:** ✅ Merged **Merged:** 3/8/2024 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `ramsay/fix-github-action-on-filter` --- ### 📝 Commits (1) - [`7cbf2db`](https://github.com/ramsayleung/rspotify/commit/7cbf2db65ac6f1c1c287ec19bb5b84b03c936328) [fix] Fix the filter of *on* event, only trigger the workflow when new tag named ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/publish.yaml` (+1 -1) </details> ### 📄 Description ## Description Fix the filter of GitHub Action on event ## Motivation and Context The `on` section specifies the events that trigger workflow, what I expect is the workflow only get triggered when new tag name `v*` is created(e.g. new version is published). However, the current configuration will trigger the workflow not only when a new tag is created but also when any other type of creation event occurs(such as creating a new branch) Fixing it by enclosing the tag pattern `'v*'` in single quotes, it should explicitly specfy that the workflow should trigger only when a new tg matching that pattern is created. ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How has this been tested? This PR shoudn't trigger the `Publish Create` workflow ## Is this change properly documented? It's unnecessary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>