[PR #455] [MERGED] Enable proxy detection when using `ureq` as HTTP client #465

New issue

Closed

opened 2026-02-27 20:24:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/455
Author: @cyqsimon
Created: 1/29/2024
Status: ✅ Merged
Merged: 1/29/2024
Merged by: @ramsayleung

Base: master ← Head: ureq-proxy

📝 Commits (1)

602aa55 Enable proxy detection when using ureq as HTTP client

📊 Changes

3 files changed (+10 additions, -4 deletions)

View changed files

📝 rspotify-http/Cargo.toml (+1 -1)
📝 rspotify-http/src/ureq.rs (+1 -0)
📝 src/lib.rs (+8 -3)

📄 Description

Description

Enable proxy detection when using ureq as HTTP client, making it consistent with using reqwest.

Motivation and Context

I found a proxy leak in hrkfdn/ncspot#1384 and traced it back to this crate.

Dependencies

None.

Type of change

Should this count as a bug fix or a new feature? I'm not sure.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
This change requires a documentation update

How has this been tested?

This is a very minor change that simply calls a function of a dependency. I think it's okay to forgo tests.

Is this change properly documented?

lib.rs documentation updated
Changelog entry pending on determining change type

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/455 **Author:** [@cyqsimon](https://github.com/cyqsimon) **Created:** 1/29/2024 **Status:** ✅ Merged **Merged:** 1/29/2024 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `ureq-proxy` --- ### 📝 Commits (1) - [`602aa55`](https://github.com/ramsayleung/rspotify/commit/602aa558f0f9fc09999ba3f28e2a8f80be920c71) Enable proxy detection when using `ureq` as HTTP client ### 📊 Changes **3 files changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `rspotify-http/Cargo.toml` (+1 -1) 📝 `rspotify-http/src/ureq.rs` (+1 -0) 📝 `src/lib.rs` (+8 -3) </details> ### 📄 Description ## Description Enable proxy detection when using `ureq` as HTTP client, making it consistent with using `reqwest`. ## Motivation and Context I found a proxy leak in hrkfdn/ncspot#1384 and traced it back to this crate. ## Dependencies None. ## Type of change Should this count as a bug fix or a new feature? I'm not sure. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] This change requires a documentation update ## How has this been tested? This is a very minor change that simply calls a function of a dependency. I think it's okay to forgo tests. ## Is this change properly documented? - [x] `lib.rs` documentation updated - [ ] Changelog entry pending on determining change type --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>