[PR #441] [MERGED] Update DeviceType to fix json parse error: unknown variant #456

New issue

Closed

opened 2026-02-27 20:24:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/441
Author: @ndoolan360
Created: 8/31/2023
Status: ✅ Merged
Merged: 9/12/2023
Merged by: @ramsayleung

Base: master ← Head: master

📝 Commits (2)

bf71771 Update DeviceType to fix json parse error: unknown variant
7477993 Fix clippy deprecation warnings

📊 Changes

4 files changed (+8 additions, -3 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 rspotify-model/src/custom_serde.rs (+1 -1)
📝 rspotify-model/src/enums/types.rs (+1 -0)
📝 tests/test_models.rs (+2 -2)

📄 Description

Description

Fix json parse error: unknown variant Smartwatch when calling device() method.

Motivation and Context

Fixes https://github.com/ramsayleung/rspotify/issues/440

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested?

I have device with Smartwatch type, calling device() method from my app using rspotify returns error above.
Changes from this pull request stop the error occurring and allow the device type 'Smartwatch' to be returned.

Is this change properly documented?

No changes in docs were made.
CHANGELOG entry has been added under bug fix for 12.0.1

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/441 **Author:** [@ndoolan360](https://github.com/ndoolan360) **Created:** 8/31/2023 **Status:** ✅ Merged **Merged:** 9/12/2023 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`bf71771`](https://github.com/ramsayleung/rspotify/commit/bf717712ccfb06028723f865e42c596333f52a76) Update DeviceType to fix json parse error: unknown variant - [`7477993`](https://github.com/ramsayleung/rspotify/commit/7477993266dbeea82ea43d79f99b32a4f27944de) Fix clippy deprecation warnings ### 📊 Changes **4 files changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `rspotify-model/src/custom_serde.rs` (+1 -1) 📝 `rspotify-model/src/enums/types.rs` (+1 -0) 📝 `tests/test_models.rs` (+2 -2) </details> ### 📄 Description ## Description Fix json parse error: unknown variant `Smartwatch` when calling device() method. ## Motivation and Context Fixes https://github.com/ramsayleung/rspotify/issues/440 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How has this been tested? I have device with Smartwatch type, calling device() method from my app using rspotify returns error above. Changes from this pull request stop the error occurring and allow the device type 'Smartwatch' to be returned. ![image](https://github.com/ramsayleung/rspotify/assets/20409659/43e83536-5bd6-477a-a3b0-81c5b5a3fd40) ## Is this change properly documented? No changes in docs were made. CHANGELOG entry has been added under bug fix for 12.0.1 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>