[PR #328] [MERGED] Replace `build_map!` macro with a function #399

New issue

Closed

opened 2026-02-27 20:24:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/328
Author: @SabrinaJewson
Created: 6/15/2022
Status: ✅ Merged
Merged: 6/24/2022
Merged by: @ramsayleung

Base: master ← Head: build-map-fn

📝 Commits (5)

49151b7 Replace build_map! macro with a function
3a016c9 Explain why iterators aren't used in build_map
f6609eb Cap comment at 80 characters
27dcfc1 Merge branch 'master' into build-map-fn
2cc8c99 Format

📊 Changes

5 files changed (+127 additions, -222 deletions)

View changed files

📝 rspotify-macros/src/lib.rs (+1 -83)
📝 src/clients/base.rs (+69 -91)
📝 src/clients/oauth.rs (+39 -48)
📝 src/lib.rs (+1 -0)
➕ src/util/mod.rs (+17 -0)

📄 Description

Description

Replaced build_map with an equivalent function.

Motivation and Context

This makes the code easier to understand I think.

Dependencies

None.

Type of change

Refactor

How has this been tested?

Test A: cargo test --features env-file

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/328 **Author:** [@SabrinaJewson](https://github.com/SabrinaJewson) **Created:** 6/15/2022 **Status:** ✅ Merged **Merged:** 6/24/2022 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `build-map-fn` --- ### 📝 Commits (5) - [`49151b7`](https://github.com/ramsayleung/rspotify/commit/49151b787ebe9275c36a293bb82974f102647049) Replace `build_map!` macro with a function - [`3a016c9`](https://github.com/ramsayleung/rspotify/commit/3a016c951f9c074764508cdb00d6b0604e1b64ef) Explain why iterators aren't used in `build_map` - [`f6609eb`](https://github.com/ramsayleung/rspotify/commit/f6609eb2e4f713c61c112736edfea2c244363644) Cap comment at 80 characters - [`27dcfc1`](https://github.com/ramsayleung/rspotify/commit/27dcfc1afc4d74daf72d1b7d1d957ce8d3a8b734) Merge branch 'master' into build-map-fn - [`2cc8c99`](https://github.com/ramsayleung/rspotify/commit/2cc8c992d0827ac3ed6933a9d0605f7feef1becc) Format ### 📊 Changes **5 files changed** (+127 additions, -222 deletions) <details> <summary>View changed files</summary> 📝 `rspotify-macros/src/lib.rs` (+1 -83) 📝 `src/clients/base.rs` (+69 -91) 📝 `src/clients/oauth.rs` (+39 -48) 📝 `src/lib.rs` (+1 -0) ➕ `src/util/mod.rs` (+17 -0) </details> ### 📄 Description ## Description Replaced `build_map` with an equivalent function. ## Motivation and Context This makes the code easier to understand I think. ## Dependencies None. ## Type of change Refactor ## How has this been tested? - [x] Test A: `cargo test --features env-file` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>