[PR #326] [MERGED] Move `clients::mutex` to `sync` module #396

New issue

Closed

opened 2026-02-27 20:24:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/326
Author: @SabrinaJewson
Created: 6/15/2022
Status: ✅ Merged
Merged: 6/15/2022
Merged by: @marioortizmanero

Base: master ← Head: sync-module

📝 Commits (4)

509d758 Move clients::mutex to sync
bb38c1a Document rspotify::sync in changelog
78b48fb Rename sync::sync to sync::blocking
0d1b615 Format

📊 Changes

13 files changed (+48 additions, -39 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 src/auth_code.rs (+4 -2)
📝 src/auth_code_pkce.rs (+4 -2)
📝 src/client_creds.rs (+4 -2)
📝 src/clients/base.rs (+1 -1)
📝 src/clients/mod.rs (+0 -1)
➖ src/clients/mutex/futures.rs (+0 -18)
➖ src/clients/mutex/mod.rs (+0 -12)
➖ src/clients/mutex/sync.rs (+0 -1)
📝 src/lib.rs (+1 -0)
➕ src/sync/blocking.rs (+1 -0)
➕ src/sync/futures.rs (+16 -0)
➕ src/sync/mod.rs (+16 -0)

📄 Description

Description

Rename clients::mutex to sync and add doc comments to it.

Motivation and Context

clients::mutex shouldn’t really be inside clients IMO because it has nothing inherently to do with the differerent clients. I was considering removing the module entirely, but I think it’s nice to keep it contained. sync is a better name than mutex since it’s more general.

Dependencies

None.

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested?

Test A: cargo test --no-default-features --features client-reqwest,reqwest-default-tls,env-file
Test B: cargo test --no-default-features --features client-ureq,ureq-rustls-tls,env-file

Is this change properly documented?

I will add a changelog entry.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/326 **Author:** [@SabrinaJewson](https://github.com/SabrinaJewson) **Created:** 6/15/2022 **Status:** ✅ Merged **Merged:** 6/15/2022 **Merged by:** [@marioortizmanero](https://github.com/marioortizmanero) **Base:** `master` ← **Head:** `sync-module` --- ### 📝 Commits (4) - [`509d758`](https://github.com/ramsayleung/rspotify/commit/509d7581d1c37a3381737731622a407cabc01174) Move `clients::mutex` to `sync` - [`bb38c1a`](https://github.com/ramsayleung/rspotify/commit/bb38c1a1ca32043337ae9f5b8a8a7397a94942a3) Document `rspotify::sync` in changelog - [`78b48fb`](https://github.com/ramsayleung/rspotify/commit/78b48fb52a95bf0ba56aadbe5a43f02748c4e438) Rename `sync::sync` to `sync::blocking` - [`0d1b615`](https://github.com/ramsayleung/rspotify/commit/0d1b6153b0c1d8078b887bd8c2664021643eed41) Format ### 📊 Changes **13 files changed** (+48 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `src/auth_code.rs` (+4 -2) 📝 `src/auth_code_pkce.rs` (+4 -2) 📝 `src/client_creds.rs` (+4 -2) 📝 `src/clients/base.rs` (+1 -1) 📝 `src/clients/mod.rs` (+0 -1) ➖ `src/clients/mutex/futures.rs` (+0 -18) ➖ `src/clients/mutex/mod.rs` (+0 -12) ➖ `src/clients/mutex/sync.rs` (+0 -1) 📝 `src/lib.rs` (+1 -0) ➕ `src/sync/blocking.rs` (+1 -0) ➕ `src/sync/futures.rs` (+16 -0) ➕ `src/sync/mod.rs` (+16 -0) </details> ### 📄 Description ## Description Rename `clients::mutex` to `sync` and add doc comments to it. ## Motivation and Context `clients::mutex` shouldn’t really be inside `clients` IMO because it has nothing inherently to do with the differerent clients. I was considering removing the module entirely, but I think it’s nice to keep it contained. `sync` is a better name than `mutex` since it’s more general. ## Dependencies None. ## Type of change - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] This change requires a documentation update ## How has this been tested? - [x] Test A: `cargo test --no-default-features --features client-reqwest,reqwest-default-tls,env-file` - [x] Test B: `cargo test --no-default-features --features client-ureq,ureq-rustls-tls,env-file` ## Is this change properly documented? I will add a changelog entry. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>