[PR #293] [CLOSED] Unbound Send marker if compile target is wasm32 #378

New issue

Closed

opened 2026-02-27 20:24:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/293
Author: @tomocrafter
Created: 12/11/2021
Status: ❌ Closed

Base: master ← Head: tomo/remove-send-from-all

📝 Commits (4)

6c95acf Unbound Send marker if compile target is wasm32
eb74345 add:chrono wasmbind feature
9edb52b Supports test code for wasm-pack test
374ef45 add:wasm-test

📊 Changes

12 files changed (+170 additions, -34 deletions)

View changed files

📝 .github/workflows/ci.yml (+34 -0)
📝 Cargo.toml (+8 -2)
📝 rspotify-http/src/common.rs (+2 -1)
📝 rspotify-http/src/reqwest.rs (+2 -1)
📝 rspotify-model/Cargo.toml (+1 -1)
📝 src/auth_code.rs (+4 -2)
📝 src/auth_code_pkce.rs (+4 -2)
📝 src/client_creds.rs (+2 -1)
📝 src/clients/base.rs (+2 -1)
📝 src/clients/oauth.rs (+2 -1)
📝 tests/test_with_credential.rs (+97 -16)
📝 tests/test_with_oauth.rs (+12 -6)

📄 Description

Description

Unbounds Send marker if compile target is wasm32 to fix #292

Motivation and Context

Please also include relevant motivation and context.

Dependencies

List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Is this change properly documented?

This PR doesn't updated document. and I'm not used to write document in English proper so if anyone can, please create PR.

Please make sure you've properly documented the changes you're making.

Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements).
TBD

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/293 **Author:** [@tomocrafter](https://github.com/tomocrafter) **Created:** 12/11/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `tomo/remove-send-from-all` --- ### 📝 Commits (4) - [`6c95acf`](https://github.com/ramsayleung/rspotify/commit/6c95acfc6b881a7481ada019d254082c36651cd0) Unbound Send marker if compile target is wasm32 - [`eb74345`](https://github.com/ramsayleung/rspotify/commit/eb743451bf31ccabfca536ab8a96d122f490a39f) add:chrono wasmbind feature - [`9edb52b`](https://github.com/ramsayleung/rspotify/commit/9edb52b728d7f7237c31a604405a0e343ea68452) Supports test code for wasm-pack test - [`374ef45`](https://github.com/ramsayleung/rspotify/commit/374ef4585a0cf70f4f24e37b1d627512ebf839b7) add:wasm-test ### 📊 Changes **12 files changed** (+170 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+34 -0) 📝 `Cargo.toml` (+8 -2) 📝 `rspotify-http/src/common.rs` (+2 -1) 📝 `rspotify-http/src/reqwest.rs` (+2 -1) 📝 `rspotify-model/Cargo.toml` (+1 -1) 📝 `src/auth_code.rs` (+4 -2) 📝 `src/auth_code_pkce.rs` (+4 -2) 📝 `src/client_creds.rs` (+2 -1) 📝 `src/clients/base.rs` (+2 -1) 📝 `src/clients/oauth.rs` (+2 -1) 📝 `tests/test_with_credential.rs` (+97 -16) 📝 `tests/test_with_oauth.rs` (+12 -6) </details> ### 📄 Description ## Description Unbounds Send marker if compile target is wasm32 to fix #292 ## Motivation and Context Please also include relevant motivation and context. ## Dependencies List any dependencies that are required for this change. ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] This change requires a documentation update ## How has this been tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. ## Is this change properly documented? This PR doesn't updated document. and I'm not used to write document in English proper so if anyone can, please create PR. Please make sure you've properly documented the changes you're making. Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements). TBD --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>