[PR #283] [MERGED] Fix clippy suggestions for tests #372

New issue

Closed

opened 2026-02-27 20:24:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/283
Author: @marioortizmanero
Created: 11/19/2021
Status: ✅ Merged
Merged: 11/20/2021
Merged by: @ramsayleung

Base: fix-optional ← Head: fix-clippy

📝 Commits (5)

d3341cf Fix unnecessary references in tests
3f93374 Fix floating point comparisons
cc2b57a Formatting
8b8b1af Fix one last warning
c253c17 Tidy up example

📊 Changes

7 files changed (+47 additions, -50 deletions)

View changed files

📝 .github/workflows/ci.yml (+1 -1)
📝 examples/with_auto_reauth.rs (+13 -13)
📝 rspotify-macros/src/lib.rs (+1 -1)
📝 rspotify-model/src/device.rs (+1 -1)
📝 tests/test_models.rs (+22 -20)
📝 tests/test_oauth2.rs (+1 -1)
📝 tests/test_with_oauth.rs (+8 -13)

📄 Description

Description

Turns out we needed --all-targets in our clippy CI in order to run it for the tests as well. This has been fixed, and all the suggested improvements have been applied.

Motivation and Context

See bevy's CI: https://github.com/bevyengine/bevy/blob/main/tools/ci/src/main.rs#L16

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The CI passes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/283 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 11/19/2021 **Status:** ✅ Merged **Merged:** 11/20/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `fix-optional` ← **Head:** `fix-clippy` --- ### 📝 Commits (5) - [`d3341cf`](https://github.com/ramsayleung/rspotify/commit/d3341cf87d1a33ceef412b592111074edfa14c36) Fix unnecessary references in tests - [`3f93374`](https://github.com/ramsayleung/rspotify/commit/3f9337459f4f3dea9d83a464af58f5f226975f4c) Fix floating point comparisons - [`cc2b57a`](https://github.com/ramsayleung/rspotify/commit/cc2b57a93607611fcbddbacc6d41245e7cca2b9b) Formatting - [`8b8b1af`](https://github.com/ramsayleung/rspotify/commit/8b8b1afa9a9882f3fbca52e9024e28f941cc1889) Fix one last warning - [`c253c17`](https://github.com/ramsayleung/rspotify/commit/c253c17da53afb436b2cbe6fb72a53271813b85e) Tidy up example ### 📊 Changes **7 files changed** (+47 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+1 -1) 📝 `examples/with_auto_reauth.rs` (+13 -13) 📝 `rspotify-macros/src/lib.rs` (+1 -1) 📝 `rspotify-model/src/device.rs` (+1 -1) 📝 `tests/test_models.rs` (+22 -20) 📝 `tests/test_oauth2.rs` (+1 -1) 📝 `tests/test_with_oauth.rs` (+8 -13) </details> ### 📄 Description ## Description Turns out we needed `--all-targets` in our clippy CI in order to run it for the tests as well. This has been fixed, and all the suggested improvements have been applied. ## Motivation and Context See bevy's CI: https://github.com/bevyengine/bevy/blob/main/tools/ci/src/main.rs#L16 ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? The CI passes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>