[PR #282] [MERGED] Make FullTrack.id optional #369

New issue

Closed

opened 2026-02-27 20:24:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/282
Author: @marioortizmanero
Created: 11/19/2021
Status: ✅ Merged
Merged: 11/21/2021
Merged by: @ramsayleung

Base: master ← Head: fix-optional

📝 Commits (10+)

c518f27 Make id optional
6824fa1 Document change
805f2a1 Fix tests
d3341cf Fix unnecessary references in tests
3f93374 Fix floating point comparisons
cc2b57a Formatting
8b8b1af Fix one last warning
c253c17 Tidy up example
2740a64 Merge pull request #283 from ramsayleung/fix-clippy
e20104a Merge branch 'master' into fix-optional

📊 Changes

10 files changed (+68 additions, -64 deletions)

View changed files

📝 .github/workflows/ci.yml (+1 -1)
📝 CHANGELOG.md (+2 -1)
📝 examples/with_auto_reauth.rs (+13 -13)
📝 rspotify-macros/src/lib.rs (+1 -1)
📝 rspotify-model/src/device.rs (+1 -1)
📝 rspotify-model/src/lib.rs (+7 -4)
📝 rspotify-model/src/track.rs (+2 -1)
📝 tests/test_models.rs (+22 -20)
📝 tests/test_oauth2.rs (+1 -1)
📝 tests/test_with_oauth.rs (+18 -21)

📄 Description

Description

This fixes #279

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

The CI passes perfectly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/282 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 11/19/2021 **Status:** ✅ Merged **Merged:** 11/21/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `fix-optional` --- ### 📝 Commits (10+) - [`c518f27`](https://github.com/ramsayleung/rspotify/commit/c518f27ff91895674a1868e7227eece2fbd9000c) Make id optional - [`6824fa1`](https://github.com/ramsayleung/rspotify/commit/6824fa150d05361b0db6a906ffe919f6b65cac3f) Document change - [`805f2a1`](https://github.com/ramsayleung/rspotify/commit/805f2a100cecbd04fda691a52f043d3987e0473d) Fix tests - [`d3341cf`](https://github.com/ramsayleung/rspotify/commit/d3341cf87d1a33ceef412b592111074edfa14c36) Fix unnecessary references in tests - [`3f93374`](https://github.com/ramsayleung/rspotify/commit/3f9337459f4f3dea9d83a464af58f5f226975f4c) Fix floating point comparisons - [`cc2b57a`](https://github.com/ramsayleung/rspotify/commit/cc2b57a93607611fcbddbacc6d41245e7cca2b9b) Formatting - [`8b8b1af`](https://github.com/ramsayleung/rspotify/commit/8b8b1afa9a9882f3fbca52e9024e28f941cc1889) Fix one last warning - [`c253c17`](https://github.com/ramsayleung/rspotify/commit/c253c17da53afb436b2cbe6fb72a53271813b85e) Tidy up example - [`2740a64`](https://github.com/ramsayleung/rspotify/commit/2740a6452debd06ca45da3e9f165ca7de94fb808) Merge pull request #283 from ramsayleung/fix-clippy - [`e20104a`](https://github.com/ramsayleung/rspotify/commit/e20104abe88ac55c0db35e4ddc04a73f638c6c1e) Merge branch 'master' into fix-optional ### 📊 Changes **10 files changed** (+68 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+1 -1) 📝 `CHANGELOG.md` (+2 -1) 📝 `examples/with_auto_reauth.rs` (+13 -13) 📝 `rspotify-macros/src/lib.rs` (+1 -1) 📝 `rspotify-model/src/device.rs` (+1 -1) 📝 `rspotify-model/src/lib.rs` (+7 -4) 📝 `rspotify-model/src/track.rs` (+2 -1) 📝 `tests/test_models.rs` (+22 -20) 📝 `tests/test_oauth2.rs` (+1 -1) 📝 `tests/test_with_oauth.rs` (+18 -21) </details> ### 📄 Description ## Description This fixes #279 ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## How Has This Been Tested? The CI passes perfectly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>