[PR #268] [MERGED] Prettier docs #360

New issue

Closed

opened 2026-02-27 20:24:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/268
Author: @marioortizmanero
Created: 10/11/2021
Status: ✅ Merged
Merged: 10/12/2021
Merged by: @ramsayleung

Base: master ← Head: pretty-docs

📝 Commits (1)

c13f6f7 Prettier docs

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 Cargo.toml (+5 -2)

📄 Description

Description

We currently generate the docs for docs.rs with the reqwest client. Unfortunately, since that uses async-trait, the function signatures are horrifying:

So this just enables client-ureq for the docs:

Much better!

Dependencies

None

Type of change

Please delete options that are not relevant.

This change requires a documentation update

How Has This Been Tested?

cargo doc --no-default-features --features=cli,env-file,client-ureq --open

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/268 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 10/11/2021 **Status:** ✅ Merged **Merged:** 10/12/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `pretty-docs` --- ### 📝 Commits (1) - [`c13f6f7`](https://github.com/ramsayleung/rspotify/commit/c13f6f7b7030d9a7eb4a389ecc0598952d9372c3) Prettier docs ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+5 -2) </details> ### 📄 Description ## Description We currently generate the docs for `docs.rs` with the reqwest client. Unfortunately, since that uses async-trait, the function signatures are horrifying: ![image](https://user-images.githubusercontent.com/25647296/136866670-520fb996-a04c-4383-ae14-bcae5667fec4.png) So this just enables `client-ureq` for the docs: ![image](https://user-images.githubusercontent.com/25647296/136866697-6e789122-f142-45b3-9d9b-d8702759bd5a.png) Much better! ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] This change requires a documentation update ## How Has This Been Tested? `cargo doc --no-default-features --features=cli,env-file,client-ureq --open` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>