[PR #261] [MERGED] Implement `Default` when it is possible to #353

New issue

Closed

opened 2026-02-27 20:24:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/261
Author: @marioortizmanero
Created: 9/26/2021
Status: ✅ Merged
Merged: 10/9/2021
Merged by: @ramsayleung

Base: master ← Head: defaults

📝 Commits (4)

632ff1a Implement Default when it is possible to
d5a5169 Update changelog
97ff30d Merge branch 'master' into defaults
c6d505c Merge branch 'master' into defaults

📊 Changes

18 files changed (+36 additions, -34 deletions)

View changed files

📝 CHANGELOG.md (+2 -0)
📝 rspotify-model/src/album.rs (+4 -4)
📝 rspotify-model/src/artist.rs (+3 -3)
📝 rspotify-model/src/audio.rs (+4 -4)
📝 rspotify-model/src/auth.rs (+1 -1)
📝 rspotify-model/src/category.rs (+2 -2)
📝 rspotify-model/src/context.rs (+1 -1)
📝 rspotify-model/src/device.rs (+1 -1)
📝 rspotify-model/src/image.rs (+1 -1)
📝 rspotify-model/src/lib.rs (+1 -1)
📝 rspotify-model/src/page.rs (+3 -3)
📝 rspotify-model/src/playlist.rs (+4 -4)
📝 rspotify-model/src/recommend.rs (+1 -1)
📝 rspotify-model/src/search.rs (+1 -1)
📝 rspotify-model/src/show.rs (+3 -3)
📝 rspotify-model/src/track.rs (+2 -2)
📝 rspotify-model/src/user.rs (+1 -1)
📝 src/clients/base.rs (+1 -1)

📄 Description

Description

This adds a #[derive(Default)] where it is possible. I've also included a couple minor fixes, like renaming a model with a typo, or updating the docs of intermediate structs (i.e. holders of Vec<T> which are then simplified to just a Vec<T> in the client).

Motivation and Context

This closes #33 and leaves #223 and #221 as the only issues left for the new release :))

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Tests still pass perfectly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/261 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 9/26/2021 **Status:** ✅ Merged **Merged:** 10/9/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `defaults` --- ### 📝 Commits (4) - [`632ff1a`](https://github.com/ramsayleung/rspotify/commit/632ff1a9de9a1ab3bc2a47728a468d9b2aeffc07) Implement `Default` when it is possible to - [`d5a5169`](https://github.com/ramsayleung/rspotify/commit/d5a5169bc359f145276b7ff1442437faec8f7425) Update changelog - [`97ff30d`](https://github.com/ramsayleung/rspotify/commit/97ff30d3cfee8a565dafe59df67b98e9ef850fed) Merge branch 'master' into defaults - [`c6d505c`](https://github.com/ramsayleung/rspotify/commit/c6d505cc3ee2aac0c9de767e7fc016498ca81fe0) Merge branch 'master' into defaults ### 📊 Changes **18 files changed** (+36 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -0) 📝 `rspotify-model/src/album.rs` (+4 -4) 📝 `rspotify-model/src/artist.rs` (+3 -3) 📝 `rspotify-model/src/audio.rs` (+4 -4) 📝 `rspotify-model/src/auth.rs` (+1 -1) 📝 `rspotify-model/src/category.rs` (+2 -2) 📝 `rspotify-model/src/context.rs` (+1 -1) 📝 `rspotify-model/src/device.rs` (+1 -1) 📝 `rspotify-model/src/image.rs` (+1 -1) 📝 `rspotify-model/src/lib.rs` (+1 -1) 📝 `rspotify-model/src/page.rs` (+3 -3) 📝 `rspotify-model/src/playlist.rs` (+4 -4) 📝 `rspotify-model/src/recommend.rs` (+1 -1) 📝 `rspotify-model/src/search.rs` (+1 -1) 📝 `rspotify-model/src/show.rs` (+3 -3) 📝 `rspotify-model/src/track.rs` (+2 -2) 📝 `rspotify-model/src/user.rs` (+1 -1) 📝 `src/clients/base.rs` (+1 -1) </details> ### 📄 Description ## Description This adds a `#[derive(Default)]` where it is possible. I've also included a couple minor fixes, like renaming a model with a typo, or updating the docs of intermediate structs (i.e. holders of `Vec<T>` which are then simplified to just a `Vec<T>` in the client). ## Motivation and Context This closes #33 and leaves #223 and #221 as the only issues left for the new release :)) ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] This change requires a documentation update ## How Has This Been Tested? Tests still pass perfectly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>